Fix DND onto Task Manager for groups, group dialog scrollbar
ClosedPublic

Authored by hein on Jun 15 2017, 10:16 PM.

Details

Summary

With this patch drag-hover activation will work for group children,
and moving between different group parents while dragging will
correctly refresh the dialog contents.
BUG:379888

The patch also makes GroupDialog more similar to CompactApplet in
desktoppackage/, in particular managing applet status and activa-
ting the window explicitly. There is no concrete reason for this,
but it seemed like a good idea while debugging the DND issues.

Further, while inverting the MouseHandler<>ScrollArea nesting I
removed some dodgy geometry-setting code for the inside item, and
the ScrollArea viewport now is a single item. This very likely
addresses some reports that the scrollbar sometimes wouldn't appear
when required.
BUG:379037

Diff Detail

Repository
R119 Plasma Desktop
Branch
Plasma/5.8
Lint
No Linters Available
Unit
No Unit Test Coverage
hein created this revision.Jun 15 2017, 10:16 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 15 2017, 10:16 PM
hein updated this revision to Diff 15481.Jun 15 2017, 10:22 PM

Slightly simpler + better comment.

hein updated this revision to Diff 15482.Jun 15 2017, 10:26 PM

Set aboutToPopulate always, and before setting the rootIndex.

Fixes pre-selecting the active window when moving the dialog
from one group to another during drag hover.

davidedmundson accepted this revision.Jun 15 2017, 10:29 PM
This revision is now accepted and ready to land.Jun 15 2017, 10:29 PM
hein updated this revision to Diff 15483.Jun 15 2017, 10:43 PM

Properly make room for scrollbar if needed.

This was kinda-sorta intended to be there (see contentWidth) but
somehow got lost during development.

hein requested review of this revision.Jun 15 2017, 10:43 PM
hein edited edge metadata.

David, you still ok with this updated rev? Sorry, was working in parallel.

hein updated this revision to Diff 15484.Jun 15 2017, 10:55 PM

Waiting for David leads to more small cleanups.

hein updated this revision to Diff 15485.Jun 15 2017, 10:57 PM

One more readonly; I'm out of stuff now.

davidedmundson accepted this revision.Jun 19 2017, 9:56 AM
This revision is now accepted and ready to land.Jun 19 2017, 9:56 AM
This revision was automatically updated to reflect the committed changes.