Adds a test
Details
Details
- Reviewers
broulik davidedmundson - Group Reviewers
Plasma - Commits
- R120:ec31a507275c: Add a test that adds a notification and closes it
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- arcpatch-D6059_1
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
This was discussed at length in https://phabricator.kde.org/D4215
What's the reasoning behind this change?
Comment Actions
triggering the action would close the notification anyways, so it may be seen as a consistency between notifications with action and not
Comment Actions
The reasoning is Kai complained about it in IRC. If it was decided against I'll redo the patch keeping the test and closing the notification differently.
Comment Actions
That's up to Kai/VDG, I guess. I was just wondering what changed
from the previous patch where everyone agreed to not do it because
it would be confusing.