Details
Details
Diff Detail
Diff Detail
- Repository
- R52 KDevelop: PHP Support
- Branch
- argument_unpacking
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
sorry Heinz, but I think the base for this patch is still wrong. Depending on what you did, here are some ideas on what you could try to resolve this situation:
# update remote git fetch # create a new branch tracking master git checkout -b wip/function-argument-unpacking -t origin/master # cherry-pick the patch(es) that implement the feature git cherry-pick ... # use git log <name of old branch> to find hashes # once done, use arc to resubmit
hope that helps
Comment Actions
lgtm otherwise
duchain/builders/declarationbuilder.h | ||
---|---|---|
147 | = nullptr; it's otherwise potentially uninitialized |
duchain/builders/declarationbuilder.h | ||
---|---|---|
147 | Should I add that to the one before as well? (m_functionDeclarationPreviousArgument) |
duchain/builders/declarationbuilder.h | ||
---|---|---|
147 | sure, or check whether it's inited in a ctor - if not, add it here (but preferrably do that in a separate patch) |