Get rid of extra margins
ClosedPublic

Authored by volkov on May 16 2017, 2:45 PM.

Details

Diff Detail

Repository
R104 KScreen
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
volkov created this revision.May 16 2017, 2:45 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 16 2017, 2:45 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson added inline comments.
kcm/src/widget.cpp
82

why?

mart added a subscriber: mart.May 17 2017, 9:20 AM

when visual changes are involved, always include a screenshot in the review request

volkov added inline comments.May 17 2017, 10:53 AM
kcm/src/widget.cpp
82

To remove redundant spacing from the bottom part, you can see it on the screenshot.

mart added inline comments.May 17 2017, 11:18 AM
kcm/src/widget.cpp
82

i would prefer the margins to be all zero, that -1 looks a bit magic, even if would make things look slightly better, i vote for code cleanliness

volkov updated this revision to Diff 14632.May 17 2017, 11:55 AM

set margin size explicitly instead of using magic value -1

davidedmundson accepted this revision.May 17 2017, 12:18 PM
This revision is now accepted and ready to land.May 17 2017, 12:18 PM
This revision was automatically updated to reflect the committed changes.