Use the first thumbnail as icon for KNS resources
ClosedPublic

Authored by leinir on May 8 2017, 2:48 PM.

Details

Summary

Rather than using the same icon for all KNS based resources, this will return the URL for the first screenshot item.

Diff Detail

Repository
R134 Discover Software Store
Lint
Lint Skipped
Unit
Unit Tests Skipped
leinir created this revision.May 8 2017, 2:48 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 8 2017, 2:48 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
leinir updated this revision to Diff 14291.May 8 2017, 2:56 PM

Have a slightly more useful fallback icon than just nothing (that is, if there is no first thumbnail, use the one it used previously)

apol edited edge metadata.May 8 2017, 9:54 PM

Let's wait until Kirigami 2.2

apol accepted this revision.May 27 2017, 3:17 PM

Or we apply it for master and hope Kirigami 2.2 is released before next Plasma release.

This revision is now accepted and ready to land.May 27 2017, 3:17 PM
mart added a subscriber: mart.May 30 2017, 9:04 AM
In D5768#112114, @apol wrote:

Or we apply it for master and hope Kirigami 2.2 is released before next Plasma release.

we can make it happen soon.
i just wanted to know if scroll wheel behavior is alright now, then for what i'm concerned we can release

apol added a comment.May 30 2017, 2:20 PM
In D5768#112774, @mart wrote:
In D5768#112114, @apol wrote:

Or we apply it for master and hope Kirigami 2.2 is released before next Plasma release.

we can make it happen soon.
i just wanted to know if scroll wheel behavior is alright now, then for what i'm concerned we can release

Eh... scroll isn't great, haven't had time to spend on it though. You can do a quick test, you'll see.

apol added a comment.May 30 2017, 3:39 PM

@leinir remember to close BUG: 360675 with this one.

This revision was automatically updated to reflect the committed changes.