Expose PlasmaWindow::pid through WaylandTasksModel.
ClosedPublic
Actions

Authored by hein on May 8 2017, 12:12 AM.

Details

Reviewers

Group Reviewers

Plasma

Commits

Summary

Depends on D5747.

Repository

R108 KWin

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Commit embargo till 5.10 is branched.

libtaskmanager/waylandtasksmodel.cpp
340 ↗	(On Diff #14259)	You are aware that pid is not always correct? Any process started by KWin shares KWin pid. Given that one need to be careful outside of KWin. You should not base any decisions on it and especially not try to close apps based on pid.

Put code working with the client connection into ShellClient.

Fix commit subject.

Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptMay 8 2017, 9:55 AM

Restricted Application added subscribers: KWin, kwin. · View Herald Transcript

Argh, the lack of sleep ... I updated the wrong Phab. Give me a few mins ;)

libtaskmanager/waylandtasksmodel.cpp
340 ↗	(On Diff #14259)	Yeah, I'm aware based on how ClientConnection must work. I'll enhance the AppPid role apidox in the abstract model. It's fine with how it's being used currently.

Document the limitations of the AppPid data role better.

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptMay 8 2017, 10:07 AM

Obviously commit embargo till 5.10 is branched is still in place.

This revision is now accepted and ready to land.May 8 2017, 4:04 PM

This revision was automatically updated to reflect the committed changes.

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	14259	16629c8		May 8 2017, 12:11 AM	★	★
Diff 2	14267	8e23786	Put code working with the client connection into ShellClient.	May 8 2017, 9:55 AM	★	★
Diff 3	14272	16629c8	Document the limitations of the AppPid data role better.	May 8 2017, 10:07 AM	★	★
Diff 4	14465	5324f52	R120:140c65f2236bffa9bbe1eaae423b7fea0b2d3ede	May 13 2017, 3:27 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
c77143f14999	4a82def77060	8e237862fe54	Eike Hein	Set pid on the PlasmaWindow based on the client connection. (Show More…)	May 8 2017, 12:44 AM

Status	Author	Revision
Closed	hein	D5756 Set pid on the ClientConnection backing the PlasmaWindow surface.
Abandoned	hein	D5812 Add missing block to make sure initial pid is sent
Closed	hein	D5818 Lift app identification heuristic out of XWindowTasksModel and share it with WaylandTasksModel.
Closed	hein	D5755 Expose PlasmaWindow::pid through WaylandTasksModel.
Closed	sebas	D5747 add pid to plasma window management protocol