add again a fake entry called current like there used to be,
add an "Apply" button in the color scheme editor (when not in
standalone app mode) hitting apply will apply whatever custom
set without saving it, will be accessible trough the "current"
entry.
Details
- Reviewers
davidedmundson - Group Reviewers
Plasma - Commits
- R119:ec1f70b35631: restore the "current" color scheme concept
changed a single color in the set, gets correctly applied
Diff Detail
- Repository
- R119 Plasma Desktop
- Branch
- arcpatch-D5411
- Lint
No Linters Available - Unit
No Unit Test Coverage
You've exlained what the patch does, but you've not said why you're doing it.
What does this achieve?
kcms/colors/colorscm.cpp | ||
---|---|---|
134 | What is this about? | |
413 | Heh, there's some leftovers of the old code here. At least it makes adding this back easier :) | |
444 | Sometime's we're comparing the name to find out which is "default" sometimes using index. | |
455–457 | If the current design is for saving to be handled by signaling from the dialog to the KCM which does the actual saving. You should handle apply in the same way. |
adress issues
kcms/colors/colorscm.cpp | ||
---|---|---|
134 | this is just copied from the old revision before the current entry was removed... | |
455–457 | no, the saving is handled completely in the editor dialog. |