[desktop:/ KIO] Add descriptive name for root item
ClosedPublic

Authored by broulik on Mar 28 2017, 3:04 PM.

Details

Summary

This way Folder View could use the root item for its heading instead of special-casing it for desktop:/

Test Plan

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Mar 28 2017, 3:04 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 28 2017, 3:04 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein accepted this revision.Mar 28 2017, 3:52 PM
This revision is now accepted and ready to land.Mar 28 2017, 3:52 PM
dfaure requested changes to this revision.Mar 29 2017, 7:11 AM
dfaure added inline comments.
kioslave/desktop/kio_desktop.cpp
171

This will be wrong in subdirs of desktop:/, as you mentioned in the description, no?

You can do if (requestedUrl().path() == "/" && ....)
where requestedUrl() is a method from the base class ForwardingSlaveBase.

This revision now requires changes to proceed.Mar 29 2017, 7:11 AM
broulik updated this revision to Diff 12946.Mar 29 2017, 8:40 AM
broulik edited edge metadata.
  • Check for requested url path being "/"
broulik edited the test plan for this revision. (Show Details)Mar 29 2017, 8:41 AM
dfaure accepted this revision.Mar 31 2017, 8:58 PM
This revision is now accepted and ready to land.Mar 31 2017, 8:58 PM
This revision was automatically updated to reflect the committed changes.