Details
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
From the the documentation of QObject::~QObject: "Warning: Deleting a QObject while pending events are waiting to be delivered can cause a crash."
It can happens only if an object lives in a different thread. But the ErrorOverlay - is a widget, which should live in a main thread.
From the the documentation of QObject::~QObject: "Warning: Deleting a QObject while pending events are waiting to be delivered can cause a crash."
It can happens only if an object lives in a different thread. But the ErrorOverlay - is a widget, which should live in a main thread.
That is not true.
If I have two things that connect to the same signal, I get two things in my event queue. Multiple things in the event queue happens all the time.
If one slot deletes something another second slot implicitly relies on, I can get a crash, no threads needed.
In this particular case as nothing is connected to that widget it seems you're right it wont' be a problem, but not for the reason you said.
FWIW, QPointer is the natural replacement for QWeakPointer and it has practically no overhead.
Ok, abstaining.
David you should commit it since AFAICS Denis does not have commit access.
Can I get a "commit access"? If yes, then how? I have read many WiKi's pages about KDE commit policy and so on.. But I did not understand how it works with KDE? Could you please recommend for me some appropriate wiki?
PS: I know how to work with Qt's JIRA, but the KDE's confused for me. :)
https://community.kde.org/Infrastructure/Get_a_Developer_Account
"After you obtained your KDE Identity, visit the Developer Application page to apply for a KDE Developer Account."
"Normally, any developer who has done some work on projects hosted by KDE can apply for a KDE Developer account. "
I don't think that one commit is enough, but KDE developers can commit instead of you.
Don't stuck on one change.