Differential D4764

KCM: Switch tabs with mouse wheel
ClosedPublic
Actions

Authored by drosca on Feb 24 2017, 3:49 PM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R115:87df4c77cb69: KCM: Switch tabs with mouse wheel
R994:87df4c77cb69: KCM: Switch tabs with mouse wheel
Summary

In QtWidgets tabbar it is possible to switch tabs with mouse wheel,
but in QtQuickControls not so implement it manually.

Test Plan

Behaves like QtWidgets tabbar now

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Branch
kcm-wheel-tabswitch (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
drosca created this revision.Feb 24 2017, 3:49 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 24 2017, 3:49 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik added a subscriber: broulik.Feb 24 2017, 4:02 PM

+1 Yay QtQuick Controls…

who is it that eats the wheel events inside the pages, which is a good thing but still wondering?

src/kcm/package/contents/ui/main.qml
59

Could you just make the root Item a MouseArea instead?

drosca updated this revision to Diff 11777.Feb 24 2017, 4:06 PM

Make MouseArea root item

broulik accepted this revision.Feb 24 2017, 4:08 PM
This revision is now accepted and ready to land.Feb 24 2017, 4:08 PM
drosca added a comment.Feb 24 2017, 4:09 PM

who is it that eats the wheel events inside the pages, which is a good thing but still wondering?

No idea, honestly. It must be the contentItem of TabView.

But now I noticed that scrolling works also on 1px frame around the TabView.

Closed by commit R115:87df4c77cb69: KCM: Switch tabs with mouse wheel (authored by drosca). · Explain WhyFeb 24 2017, 4:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kcm/package/contents/ui/main.qml (44 lines)

Diff 11777

View Options

src/kcm/package/contents/ui/main.qml

Loading...