Differential D4650

[greeter] Clear clipboard on show
ClosedPublic
Actions

Authored by graesslin on Feb 17 2017, 3:23 PM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R133:6d656cb94e62: merge Plasma/5.9
R133:cae1e82fc94f: [greeter] Clear clipboard on show
Summary

As we have a feature to show the password it would be possible for an
unauthorized user to get access to the clipboard.

To prevent this, the clipboard gets cleared when we have the window
shown. This is late enough on Wayland to be able to clear the clipboard.

BUG: 376526
FIXED-IN: 5.10

Test Plan

On Wayland, paste is no longer possible. X11 is untested,
there klipper might restore clipboard content.

Diff Detail

Repository
R133 KScreenLocker
Branch
greeter-clear-clipboard
Lint
No Linters Available
Unit
No Unit Test Coverage
graesslin updated this revision to Diff 11454.Feb 17 2017, 3:23 PM
graesslin retitled this revision from to [greeter] Clear clipboard on show.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 17 2017, 3:23 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik added a subscriber: broulik.Feb 17 2017, 3:40 PM

Works fine on X.

So when I lock the screen and unlock again, my copied stuff will be gone… but then, if I lock the screen I'm probably away for an extended period of time anways.

+1

broulik accepted this revision.Feb 17 2017, 4:39 PM
broulik added a reviewer: broulik.
This revision is now accepted and ready to land.Feb 17 2017, 4:39 PM
Closed by commit R133:cae1e82fc94f: [greeter] Clear clipboard on show (authored by graesslin). · Explain WhyFeb 17 2017, 5:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mgreeter/greeterapp.cpp (2 lines)

Diff 11454

View Options

greeter/greeterapp.cpp

Loading...