Make it possible to use Ruby 2.4.0
ClosedPublic

Authored by apol on Feb 17 2017, 12:03 AM.

Details

Test Plan

Created a tarball using ruby 2.4.0

Diff Detail

Repository
R572 releaseme
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol updated this revision to Diff 11421.Feb 17 2017, 12:03 AM
apol retitled this revision from to Make it possible to use Ruby 2.4.0.
apol updated this object.
apol edited the test plan for this revision. (Show Details)
apol added a reviewer: sitter.
sitter edited edge metadata.Feb 17 2017, 12:08 AM

I think there may be a test that needs adjusting. rake test is your friend. Other tham that shipit

garg added a subscriber: garg.Feb 17 2017, 12:14 AM

Why not just define these requirements in the Gemfile?

apol added a comment.Feb 17 2017, 11:06 AM

tests don't pass in a horrible error message:

E: yard not found. Not providing related Rake task.                                                                                                                                                                                                                              
E: rubocop/rake_task not found. Not providing related Rake task.                                                                                                                                                                                                                 
/usr/bin/ruby -w -I"lib" -I"/usr/lib/ruby/gems/2.4.0/gems/rake-12.0.0/lib" "/usr/lib/ruby/gems/2.4.0/gems/rake-12.0.0/lib/rake/rake_test_loader.rb" "test/test_helper.rb"                                                                                                        
/home/apol/devel/frameworks/releaseme/test/test_helper.rb:20: warning: assigned but unused variable - e                                                                                                                                                                          
codeclimate reporter not available, not sending reports to server                                                                                                                                                                                                                
coveralls reporter not available, not sending reports to server                                                                                                                                                                                                                  
pullreview reporter not available, not sending reports to server                                                                                                                                                                                                                 
/usr/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in `require': cannot load such file -- simplecov (LoadError)                                                                                                                                                          
        from /usr/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in `require'                                                                                                                                                                                             
        from /home/apol/devel/frameworks/releaseme/test/test_helper.rb:24:in `<top (required)>'                                                                                                                                                                                  
        from /usr/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in `require'                                                                                                                                                                                             
        from /usr/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in `require'                                                                                                                                                                                             
        from /usr/lib/ruby/gems/2.4.0/gems/rake-12.0.0/lib/rake/rake_test_loader.rb:15:in `block in <main>'                                                                                                                                                                      
        from /usr/lib/ruby/gems/2.4.0/gems/rake-12.0.0/lib/rake/rake_test_loader.rb:4:in `select'                                                                                                                                                                                
        from /usr/lib/ruby/gems/2.4.0/gems/rake-12.0.0/lib/rake/rake_test_loader.rb:4:in `<main>'
rake aborted!
Command failed with status (1): [ruby -w -I"lib" -I"/usr/lib/ruby/gems/2.4.0/gems/rake-12.0.0/lib" "/usr/lib/ruby/gems/2.4.0/gems/rake-12.0.0/lib/rake/rake_test_loader.rb" "test/test_helper.rb" ]

Tasks: TOP => test
This revision was automatically updated to reflect the committed changes.