Differential D4533

Avoid a crash on Kwin decoration KCM teardown
ClosedPublic
Actions

Authored by davidedmundson on Feb 9 2017, 5:35 PM.

Details

Reviewers
graesslin
Group Reviewers
Plasma
Commits
R108:70d2fb2378d6: Avoid a crash on Kwin decoration KCM teardown
R108:29179f115c81: Avoid a crash on Kwin decoration KCM teardown
Summary

As described in https://bugreports.qt.io/browse/QTBUG-57714 exposing a
QWidget as a context item to QtQuick can crash. Especially as the
engine's context property gets deleted whilst deleting the parent item.

This patch reworks the code so that the models are exposed to QML
directly rather than going through a QWidget.

CCBUG: 373628

Test Plan

Pressing back whilst in the decoration KCM used to crash every time, now it doesn't.
I still have the buttons.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 11126.Feb 9 2017, 5:35 PM
davidedmundson retitled this revision from to Avoid a crash on Kwin decoration KCM teardown.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 9 2017, 5:35 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cfeck added a subscriber: cfeck.Feb 9 2017, 9:02 PM

Be my hero!

+1

cfeck added inline comments.Feb 9 2017, 9:05 PM
kcmkwin/kwindecoration/kcm.cpp
103–106

while you are at it, QStringLiteral?

graesslin accepted this revision.Feb 10 2017, 6:35 AM
graesslin added a reviewer: graesslin.
graesslin added a subscriber: graesslin.

Hero!

This revision is now accepted and ready to land.Feb 10 2017, 6:35 AM
Closed by commit R108:29179f115c81: Avoid a crash on Kwin decoration KCM teardown (authored by davidedmundson). · Explain WhyFeb 10 2017, 9:55 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 11151

View Options

kcmkwin/kwindecoration/kcm.h

Loading...
View Options

kcmkwin/kwindecoration/kcm.cpp

Loading...
View Options

kcmkwin/kwindecoration/qml/Buttons.qml

Loading...