Differential D4455

[System Tray Containment] Ungrab mouse before opening context menu
ClosedPublic
Actions

Authored by broulik on Feb 6 2017, 11:56 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:dfdb7296275c: [System Tray Containment] Ungrab mouse before opening context menu
R871:bcb9ede5caab: [System Tray Containment] Ungrab mouse before opening context menu
R120:bcb9ede5caab: [System Tray Containment] Ungrab mouse before opening context menu
R871:dfdb7296275c: [System Tray Containment] Ungrab mouse before opening context menu
Summary

This is the same Plasma ContainmentInterface does. Otherwise QtQuick gets confused about mouse state.

Test Plan

Right clicked applet in systray, opened applet settings. Before that I didn't get hover effects in task manager and the next click on the panel ended up clicked where I last clicked (e.g. on the applet I just opened the config dialog from)

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 10960.Feb 6 2017, 11:56 AM
broulik retitled this revision from to [System Tray Containment] Ungrab mouse before opening context menu.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 6 2017, 11:56 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Feb 6 2017, 12:04 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Feb 6 2017, 12:04 PM
Closed by commit R120:bcb9ede5caab: [System Tray Containment] Ungrab mouse before opening context menu (authored by broulik). · Explain WhyFeb 6 2017, 1:16 PM
This revision was automatically updated to reflect the committed changes.
anthonyfieroni added a subscriber: anthonyfieroni.Feb 18 2017, 3:47 PM

I'm not happy with this patch, Kai. I think ungrabbing should be done in one place, plasma-framework, and on menu destruction.

  1. Maximize window
  2. Right click on item in systray
  3. Select item from menu list
  4. Exclusive click is needed i.e. grab still stays in containment (Qt 5.8)
broulik added a comment.Feb 18 2017, 4:27 PM

Feel free to provide a better patch.

Revision Contents
Changeset List

PathPackages
Mapplets/systemtray/systemtray.cpp (4 lines)

Diff 10963

View Options

applets/systemtray/systemtray.cpp

Loading...