| broulik |
| Plasma |
Whilst using units is generally good, the wallpaper transition time is
way too short. It's a different type of animation to the others,
especially in a slideshow, where the transition is an important part of
the behaviour.
This patch loads it from a hidden configuration option with a duration
of 1000ms, if and only if animations are enabled.
Value determined through brief trial and error.
BUG: 365979
Opened wallpaper. Clicked next.
Also changed static wallpaper manually, transition looked fine
| No Linters Available |
| No Unit Test Coverage |
Just noticed I hadn't set my sails for adventure when I first saw this. Let's go with this I'd say.
| wallpapers/image/imagepackage/contents/config/main.xml | ||
|---|---|---|
| 30 | There's two spaces | |
| wallpapers/image/imagepackage/contents/ui/main.qml | ||
| 191 | This works in JS but I'd prefer it to be more explicit units.longDuration > 0 ? wallpaper.configuration.TransitionAnimationDuration : 0 (says the one who prefers foo || bar over foo ? foo : bar :D) | |