Provide kxbk config through kwinApp
ClosedPublic

Authored by graesslin on Jan 27 2017, 4:19 PM.

Details

Summary

So far KWin parsed the kxbkrc at multiple places (once in Xkb, once
in KeyboardLayout). This is now replaced by one KSharedConfigPtr hold
by kwinApp, just like the normal kwinrc. The KSharedConfigPtr is now
passed to Xkb.

As a nice side effect this makes it easier to test keyboard layout
changes as we can now properly mock the keyboard configuration. Thus
this change also comes with an autotest for loading keyboard layout
configuration. This is becoming more and more a need as we start
getting bug reports for layout specific issues like global shortcuts
not working with Greek layout.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 10631.Jan 27 2017, 4:19 PM
graesslin retitled this revision from to Provide kxbk config through kwinApp.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptJan 27 2017, 4:19 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
mart accepted this revision.Jan 30 2017, 10:01 AM
mart added a reviewer: mart.
mart added a subscriber: mart.

love it

This revision is now accepted and ready to land.Jan 30 2017, 10:01 AM
This revision was automatically updated to reflect the committed changes.