Introduce an adoption command in the wallpaper knsrc file
ClosedPublic

Authored by apol on Jan 27 2017, 1:31 PM.

Details

Summary

Using the same semantics as the InstallationCommand, makes it possible for the
client to get a kns resource adopted.

Needs further standarization, I have implemented this on Discover and seems
to work just fine.

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol updated this revision to Diff 10613.Jan 27 2017, 1:31 PM
apol retitled this revision from to [RFC] Introduce an adoption command in the wallpaper knsrc file.
apol updated this object.
apol edited the test plan for this revision. (Show Details)
apol added reviewers: Frameworks, mart, whiting, leinir.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 27 2017, 1:31 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart edited edge metadata.Jan 27 2017, 2:09 PM

this could be a nice idea.
if this goes in, the stock knewstuff install dialog should use it as well

apol added a comment.Jan 27 2017, 2:35 PM
In D4307#80774, @mart wrote:

if this goes in, the stock knewstuff install dialog should use it as well

I'm not sure. In this specific case, if you're in the KNS Dialog means that you already have the Wallpapers kcm open already, which gives a bit more control over the wallpapers.

If there's consensus, I'll be happy to implement it in the dialog too.

mart added a comment.Jan 27 2017, 4:47 PM
In D4307#80790, @apol wrote:
In D4307#80774, @mart wrote:

if this goes in, the stock knewstuff install dialog should use it as well

I'm not sure. In this specific case, if you're in the KNS Dialog means that you already have the Wallpapers kcm open already, which gives a bit more control over the wallpapers.

If there's consensus, I'll be happy to implement it in the dialog too.

that's true for the wallpaper dialog, but you don't know the other potential applications of that dialog.
i see that dialog as pretty much the reference implementation, if it doesn't implement an important feature, it becomes hard to keep track of actual knewstuff features.

apol added a comment.Feb 2 2017, 6:42 PM

Changes are in KNS now, can someone please review the patch?

apol retitled this revision from [RFC] Introduce an adoption command in the wallpaper knsrc file to Introduce an adoption command in the wallpaper knsrc file.Feb 2 2017, 6:42 PM
apol edited reviewers, added: Plasma; removed: Frameworks.
mart accepted this revision.Feb 6 2017, 6:34 PM
mart edited edge metadata.
This revision is now accepted and ready to land.Feb 6 2017, 6:34 PM
This revision was automatically updated to reflect the committed changes.