Differential D4219

Fix bug 374921: Tool view grouping no longer works in 5.1 branch
ClosedPublic
Actions

Authored by antonanikin on Jan 20 2017, 5:21 AM.

Details

Reviewers
mwolff
apol
Group Reviewers
KDevelop
Commits
R32:38fa47e9860d: Fix bug 374921: Tool view grouping no longer works in 5.1 branch
R33:38fa47e9860d: Fix bug 374921: Tool view grouping no longer works in 5.1 branch
Summary

This commit fixes view grouping, broken in D3170 revision.

BUG: 373213

Test Plan

Tested on 5.1 and master branches.

Diff Detail

Repository
R33 KDevPlatform
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
antonanikin updated this revision to Diff 10381.Jan 20 2017, 5:21 AM
antonanikin retitled this revision from to Fix bug 374921: Tool view grouping no longer works in 5.1 branch.
antonanikin updated this object.
antonanikin edited the test plan for this revision. (Show Details)
antonanikin added reviewers: KDevelop, apol.
antonanikin added a subscriber: kdevelop-devel.
mwolff accepted this revision.Jan 22 2017, 7:40 PM
mwolff added a reviewer: mwolff.
mwolff added a subscriber: mwolff.

assuming this actually fixes it, I'm all for it - less code :)

This still works b/c you pushed the grouping functionality into the showWidget code path, right? Nice work!

This revision is now accepted and ready to land.Jan 22 2017, 7:40 PM
Closed by commit R33:38fa47e9860d: Fix bug 374921: Tool view grouping no longer works in 5.1 branch (authored by antonanikin). · Explain WhyJan 23 2017, 5:07 AM
This revision was automatically updated to reflect the committed changes.
antonanikin added a comment.Jan 23 2017, 5:20 AM

@mwolff, Aleix reorganize code in the D3170 revision and now we can drop buttonPressed() method - all checks can be made inside showWidget(). And you are right - less code is good :)

antonanikin added a comment.Jan 23 2017, 5:21 AM

Also sorry for mistake with bug number inside revision description.

Revision Contents
Changeset List

Diff 10381

View Options

sublime/idealbuttonbarwidget.h

Loading...
View Options

sublime/idealbuttonbarwidget.cpp

Loading...