Differential D4165

Drop KWin's internal global shortcut handling
ClosedPublic
Actions

Authored by graesslin on Jan 16 2017, 8:45 PM.

Details

Reviewers
romangg
Group Reviewers
Plasma
KWin
Commits
R108:32f4e115e2c6: Drop KWin's internal global shortcut handling
Summary

During the Wayland porting a KWin internal global shortcut handling got
implemented prior to the porting of KGlobalAccel. This allowed to trigger
global shortcuts with a KGlobalAccel still on X11 and unknown to KWin.

Nowadays KWin directly provides KGlobalAccel, thus it's no longer
required. The code was runtime dead as we always have a KGlobalAccel.

Diff Detail

Repository
R108 KWin
Branch
drop-internal-global-shortcuts
Lint
No Linters Available
Unit
No Unit Test Coverage
graesslin updated this revision to Diff 10257.Jan 16 2017, 8:45 PM
graesslin retitled this revision from to Drop KWin's internal global shortcut handling.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: Plasma, KWin.
Restricted Application added a project: KWin. · View Herald TranscriptJan 16 2017, 8:45 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
romangg added a subscriber: romangg.Jan 17 2017, 9:50 AM
romangg added inline comments.
globalshortcuts.cpp
173

getShortcutForAction was only called here, so you could remove this function aswell?

graesslin updated this revision to Diff 10288.Jan 17 2017, 4:08 PM
  • Rebased to current master
  • Dropped no longer needed private method
  • which in turn allowed to drop kconfig
Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptJan 17 2017, 4:08 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
graesslin updated this revision to Diff 10289.Jan 17 2017, 4:10 PM

And drop some no longer needed includes

Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptJan 17 2017, 4:10 PM
romangg accepted this revision.Jan 17 2017, 4:46 PM
romangg added a reviewer: romangg.
This revision is now accepted and ready to land.Jan 17 2017, 4:46 PM
Closed by commit R108:32f4e115e2c6: Drop KWin's internal global shortcut handling (authored by graesslin). · Explain WhyJan 18 2017, 6:11 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mglobalshortcuts.h (8 lines)
Mglobalshortcuts.cpp (34 lines)
Minput.cpp (1 line)

Diff 10257

View Options

globalshortcuts.h

Loading...
View Options

globalshortcuts.cpp

Loading...
View Options

input.cpp

Loading...