Add a "clear" button and related code for the OutputView
ClosedPublic

Authored by tcanabrava on Jan 13 2017, 5:41 PM.

Details

Summary

Adds a clear button and related code for the OutputView,
sometimes the amount of text inside of the OutputView is just
too much and we wanna clear, not filter, the dialog to be
able to look at new strings comming in.

Also, a few cleanups on some files regarding dead code and
micro-opts.

Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org>

Test Plan

manual testing

Diff Detail

Repository
R33 KDevPlatform
Branch
clear_ouput_view
Lint
No Linters Available
Unit
No Unit Test Coverage
tcanabrava updated this revision to Diff 10152.Jan 13 2017, 5:41 PM
tcanabrava retitled this revision from to Add a "clear" button and related code for the OutputView.
tcanabrava edited the test plan for this revision. (Show Details)
tcanabrava added reviewers: kfunk, apol.
tcanabrava updated this object.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJan 13 2017, 5:41 PM
kfunk accepted this revision.Jan 13 2017, 11:14 PM
kfunk edited edge metadata.

Rest LGTM, feel free to push directly to master after the fixups.

plugins/standardoutputview/outputwidget.cpp
178

I'd factor that out into a clearOutput slot, IMO too much code for a lambda body (opinions may vary). I consider like up to 1-3 LOC suitable for a lambda.

184

auto proxy = ...

185

qobject_cast

This revision is now accepted and ready to land.Jan 13 2017, 11:15 PM
This revision was automatically updated to reflect the committed changes.
kfunk added a comment.Feb 14 2017, 7:42 AM

Thanks for linking to the related bug report, Damir!