Differential D4103

Support spring-loading on drag hover and drops into preview popups.
ClosedPublic
Actions

Authored by hein on Jan 12 2017, 1:47 PM.

Details

Reviewers
davidedmundson
broulik
Group Reviewers
Plasma
Commits
R119:383cf19d0a91: Support spring-loading on drag hover and drops into preview popups.
Summary

Woo.

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
hein updated this revision to Diff 10100.Jan 12 2017, 1:47 PM
hein retitled this revision from to Support spring-loading on drag hover and drops into preview popups..
hein updated this object.
hein edited the test plan for this revision. (Show Details)
hein added reviewers: Plasma, broulik.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 12 2017, 1:47 PM
hein updated this revision to Diff 10103.Jan 12 2017, 2:15 PM
  • Fix for older Qt Quicks which don't support recursive aliases.
  • Fix ReferenceError for 'dialog'.
hein updated this revision to Diff 10105.Jan 12 2017, 2:36 PM

Fix logic for hiding the actions button column.

hein updated this revision to Diff 10107.Jan 12 2017, 3:37 PM

Don't close nested dialog when dragging from it to a parent dialog.

hein added a comment.Jan 12 2017, 3:55 PM

Note: There are still some bugs in this, I'll update it further.

hein updated this revision to Diff 10108.Jan 12 2017, 4:12 PM

"Close" (actually: hide, then lazy-destroy) dialogs again when
moving to a parent dialog and hovering a different folder item.

hein updated this revision to Diff 10109.Jan 12 2017, 4:13 PM

Remove stray debug print.

hein added a comment.Jan 12 2017, 4:16 PM

OK, please review this now.

davidedmundson accepted this revision.Jan 13 2017, 9:27 AM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Jan 13 2017, 9:27 AM
broulik edited edge metadata.Jan 16 2017, 12:47 PM

In list view mode I now get glitched out popups appearing (probably shouldn't do anything in list view mode, or navigate to the folder like Dolphin, but not spawn popups that span the entire screen width) and the index is off by one there, too.

Icon mode is marvellous, though.

hein updated this revision to Diff 10275.Jan 17 2017, 9:32 AM
hein edited edge metadata.

Full spring-loading support for list view mode including CompactRepr.

hein updated this revision to Diff 10548.Jan 25 2017, 2:54 PM

Fix internal DND in listview mode when changing URL mid-drag.

It crashed, and also wouldn't work even without the crash.

hein updated this revision to Diff 10549.Jan 25 2017, 3:40 PM

Rebase patch to drop unrelated change from diff shown in Phab.

hein updated this revision to Diff 10551.Jan 25 2017, 3:51 PM

Don't forget to null hoveredItem.

broulik accepted this revision.Jan 25 2017, 3:57 PM
broulik edited edge metadata.
Closed by commit R119:383cf19d0a91: Support spring-loading on drag hover and drops into preview popups. (authored by hein). · Explain WhyJan 25 2017, 6:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 10108

View Options

containments/desktop/package/contents/ui/FolderItemDelegate.qml

Loading...
View Options

containments/desktop/package/contents/ui/FolderView.qml

Loading...
View Options

containments/desktop/package/contents/ui/FolderViewDialog.qml

Loading...
View Options

containments/desktop/package/contents/ui/FolderViewDropArea.qml

Loading...
View Options

containments/desktop/package/contents/ui/main.qml

Loading...
View Options

containments/desktop/plugins/folder/foldermodel.h

Loading...
View Options

containments/desktop/plugins/folder/foldermodel.cpp

Loading...