Changeset View
Changeset View
Standalone View
Standalone View
lookandfeel/contents/lockscreen/LockScreenUi.qml
| Show First 20 Lines • Show All 62 Lines • ▼ Show 20 Line(s) | 30 | PlasmaCore.ColorScope { | |||
|---|---|---|---|---|---|
| 63 | 63 | | |||
| 64 | Loader { | 64 | Loader { | ||
| 65 | id: changeSessionComponent | 65 | id: changeSessionComponent | ||
| 66 | active: false | 66 | active: false | ||
| 67 | source: "ChangeSession.qml" | 67 | source: "ChangeSession.qml" | ||
| 68 | visible: false | 68 | visible: false | ||
| 69 | } | 69 | } | ||
| 70 | 70 | | |||
| 71 | Item { | 71 | Item { | ||
graesslin: Why the change to MouseArea? | |||||
mart: to dismiss the keyboard by clicking anywhere in an empty area | |||||
| 72 | id: lockScreenRoot | 72 | id: lockScreenRoot | ||
| 73 | 73 | | |||
| 74 | x: parent.x | 74 | x: parent.x | ||
| 75 | y: parent.y | 75 | y: parent.y | ||
| 76 | width: parent.width | 76 | width: parent.width | ||
| 77 | height: parent.height | 77 | height: parent.height | ||
| 78 | 78 | | |||
| 79 | Component.onCompleted: PropertyAnimation { id: launchAnimation; target: lockScreenRoot; property: "opacity"; from: 0; to: 1; duration: 1000 } | 79 | Component.onCompleted: PropertyAnimation { id: launchAnimation; target: lockScreenRoot; property: "opacity"; from: 0; to: 1; duration: 1000 } | ||
| 80 | 80 | | |||
| 81 | states: [ | 81 | states: [ | ||
This is not related to the described change. Do we really want to close when clicking outside the keyboard? That could be rather annoying? Anyway I think it should not be bundled with a change saying it's about animations graesslin: This is not related to the described change. Do we really want to close when clicking outside… | |||||
that's how on screen keyboards usually work on pretty much any device. mart: that's how on screen keyboards usually work on pretty much any device.
removed from this, will… | |||||
Fair enough, but then it should be a Touch enabled field and not a MouseArea? graesslin: > that's how on screen keyboards usually work on pretty much any device.
Fair enough, but then… | |||||
mart: good point | |||||
| 82 | State { | 82 | State { | ||
| 83 | name: "onOtherSession" | 83 | name: "onOtherSession" | ||
| 84 | // for slide out animation | 84 | // for slide out animation | ||
| 85 | PropertyChanges { target: lockScreenRoot; y: lockScreenRoot.height } | 85 | PropertyChanges { target: lockScreenRoot; y: lockScreenRoot.height } | ||
| 86 | // we also change the opacity just to be sure it's not visible even on unexpected screen dimension changes with possible race conditions | 86 | // we also change the opacity just to be sure it's not visible even on unexpected screen dimension changes with possible race conditions | ||
| 87 | PropertyChanges { target: lockScreenRoot; opacity: 0 } | 87 | PropertyChanges { target: lockScreenRoot; opacity: 0 } | ||
| 88 | } | 88 | } | ||
| 89 | ] | 89 | ] | ||
| Show All 14 Lines | 101 | onRunningChanged: { | |||
| 104 | if (/* lockScreenRoot.state == "onOtherSession" && */ !running) { | 104 | if (/* lockScreenRoot.state == "onOtherSession" && */ !running) { | ||
| 105 | mainStack.currentItem.switchSession() | 105 | mainStack.currentItem.switchSession() | ||
| 106 | } | 106 | } | ||
| 107 | } | 107 | } | ||
| 108 | } | 108 | } | ||
| 109 | 109 | | |||
| 110 | ColumnLayout { | 110 | ColumnLayout { | ||
| 111 | anchors.top: parent.top | 111 | anchors.top: parent.top | ||
| 112 | anchors.bottom: parent.verticalCenter | 112 | anchors.bottom: parent.verticalCenter | ||
Could you please rebase this to the changes introduces with 097db85e297aba8b4b3f0ddabcddf8a03b5482c0 graesslin: Could you please rebase this to the changes introduces with… | |||||
i see that commit puts the clock in a column layout together with just an empty item.. why? looks like some easy cleanup can be done there in adapting to that diff, now hiding the user icon when it goes over the clock, but i think the clock sliding away was actually more correct ui-wise mart: i see that commit puts the clock in a column layout together with just an empty item.. why? | |||||
purely ui-wise, i think the correct behavior of the clock (for a future review) should be:
mart: purely ui-wise, i think the correct behavior of the clock (for a future review) should be:
*… | |||||
yeah hiding the clock if it overlaps with the user icon would be a good thing. I didn't see an easy way for it, but well me and QML ;-) graesslin: yeah hiding the clock if it overlaps with the user icon would be a good thing. I didn't see an… | |||||
this way seems to behave as intended, i tried to resize the lockscreen test window to various sizes that may be challenging and seems to behave quite well mart: this way seems to behave as intended, i tried to resize the lockscreen test window to various… | |||||
| 113 | anchors.horizontalCenter: parent.horizontalCenter | 113 | anchors.horizontalCenter: parent.horizontalCenter | ||
| 114 | Clock { | 114 | Clock { | ||
| 115 | id: clock | ||||
| 115 | Layout.alignment: Qt.AlignBaseline | 116 | Layout.alignment: Qt.AlignBaseline | ||
| 116 | } | 117 | } | ||
| 117 | Item { | 118 | Item { | ||
| 118 | Layout.maximumHeight: units.gridUnit * 13 | 119 | Layout.maximumHeight: units.gridUnit * 13 | ||
| 119 | Layout.fillHeight: true | 120 | Layout.fillHeight: true | ||
| 120 | } | 121 | } | ||
| 121 | } | 122 | } | ||
| 122 | 123 | | |||
| 123 | ListModel { | 124 | ListModel { | ||
| 124 | id: users | 125 | id: users | ||
| 125 | 126 | | |||
| 126 | Component.onCompleted: { | 127 | Component.onCompleted: { | ||
| 127 | users.append({name: kscreenlocker_userName, | 128 | users.append({name: kscreenlocker_userName, | ||
| 128 | realName: kscreenlocker_userName, | 129 | realName: kscreenlocker_userName, | ||
| 129 | icon: kscreenlocker_userImage, | 130 | icon: kscreenlocker_userImage, | ||
| 130 | 131 | | |||
| 131 | }) | 132 | }) | ||
| 132 | } | 133 | } | ||
| 133 | } | 134 | } | ||
| 134 | 135 | | |||
| 135 | ColumnLayout { | 136 | | ||
| 136 | anchors.fill: parent | | |||
| 137 | StackView { | 137 | StackView { | ||
| 138 | id: mainStack | 138 | id: mainStack | ||
| 139 | Layout.fillWidth: true | 139 | anchors { | ||
| 140 | Layout.fillHeight: true | 140 | left: parent.left | ||
| 141 | right: parent.right | ||||
| 142 | } | ||||
| 143 | height: lockScreenRoot.height | ||||
| 141 | focus: true //StackView is an implicit focus scope, so we need to give this focus so the item inside will have it | 144 | focus: true //StackView is an implicit focus scope, so we need to give this focus so the item inside will have it | ||
| 142 | 145 | | |||
| 143 | initialItem: MainBlock { | 146 | initialItem: MainBlock { | ||
| 144 | id: mainBlock | 147 | id: mainBlock | ||
| 145 | 148 | | |||
| 149 | showUserList: userList.y + mainStack.y > clock.height | ||||
| 146 | Stack.onStatusChanged: { | 150 | Stack.onStatusChanged: { | ||
| 147 | // prepare for presenting again to the user | 151 | // prepare for presenting again to the user | ||
| 148 | if (Stack.status == Stack.Activating) { | 152 | if (Stack.status == Stack.Activating) { | ||
| 149 | mainPasswordBox.remove(0, mainPasswordBox.length) | 153 | mainPasswordBox.remove(0, mainPasswordBox.length) | ||
| 150 | mainPasswordBox.focus = true | 154 | mainPasswordBox.focus = true | ||
| 151 | } | 155 | } | ||
| 152 | } | 156 | } | ||
| 153 | userListModel: users | 157 | userListModel: users | ||
| Show All 27 Lines | |||||
| 181 | Loader { | 185 | Loader { | ||
| 182 | Layout.fillWidth: true | 186 | Layout.fillWidth: true | ||
| 183 | Layout.preferredHeight: item ? item.implicitHeight : 0 | 187 | Layout.preferredHeight: item ? item.implicitHeight : 0 | ||
| 184 | active: true // TODO configurable | 188 | active: true // TODO configurable | ||
| 185 | source: "MediaControls.qml" | 189 | source: "MediaControls.qml" | ||
| 186 | } | 190 | } | ||
| 187 | } | 191 | } | ||
| 188 | } | 192 | } | ||
| 193 | | ||||
| 189 | Loader { | 194 | Loader { | ||
| 190 | id: inputPanel | 195 | id: inputPanel | ||
| 191 | property bool keyboardActive: item ? item.active : false | 196 | state: "hidden" | ||
| 192 | Layout.fillWidth: true | 197 | readonly property bool keyboardActive: item ? item.active : false | ||
| 193 | Layout.preferredHeight: item ? (item.active ? item.implicitHeight : 0) : 0 | 198 | anchors { | ||
| 199 | left: parent.left | ||||
| 200 | right: parent.right | ||||
| 201 | } | ||||
| 194 | function showHide() { | 202 | function showHide() { | ||
| 195 | if (Qt.inputMethod.visible) { | 203 | state = state == "hidden" ? "visible" : "hidden"; | ||
| 196 | Qt.inputMethod.hide(); | 204 | } | ||
| 197 | } else { | 205 | Component.onCompleted: inputPanel.source = "VirtualKeyboard.qml" | ||
| 198 | item.activated = true; | 206 | | ||
| 207 | states: [ | ||||
| 208 | State { | ||||
| 209 | name: "visible" | ||||
| 210 | PropertyChanges { | ||||
| 211 | target: mainStack | ||||
| 212 | y: Math.min(0, lockScreenRoot.height - inputPanel.height - mainBlock.visibleBoundary) | ||||
| 213 | } | ||||
| 214 | PropertyChanges { | ||||
| 215 | target: inputPanel | ||||
| 216 | y: lockScreenRoot.height - inputPanel.height | ||||
| 217 | opacity: 1 | ||||
| 218 | } | ||||
| 219 | }, | ||||
| 220 | State { | ||||
| 221 | name: "hidden" | ||||
| 222 | PropertyChanges { | ||||
| 223 | target: mainStack | ||||
| 224 | y: 0 | ||||
| 225 | } | ||||
| 226 | PropertyChanges { | ||||
| 227 | target: inputPanel | ||||
| 228 | y: lockScreenRoot.height - lockScreenRoot.height/4 | ||||
I'm especially afraid of reintroducing units here with a fixed multiplier. That was exactly the thing causing problems with scaling and the clock. graesslin: I'm especially afraid of reintroducing units here with a fixed multiplier. That was exactly the… | |||||
this is not really a functional position: mart: this is not really a functional position:
this is when the keyboard is hidden and its opacity… | |||||
| 229 | opacity: 0 | ||||
| 230 | } | ||||
| 231 | } | ||||
| 232 | ] | ||||
| 233 | transitions: [ | ||||
| 234 | Transition { | ||||
| 235 | from: "hidden" | ||||
| 236 | to: "visible" | ||||
| 237 | SequentialAnimation { | ||||
| 238 | ScriptAction { | ||||
| 239 | script: { | ||||
| 240 | inputPanel.item.active = true; | ||||
| 199 | Qt.inputMethod.show(); | 241 | Qt.inputMethod.show(); | ||
| 200 | } | 242 | } | ||
| 201 | } | 243 | } | ||
| 202 | Component.onCompleted: inputPanel.source = "VirtualKeyboard.qml" | 244 | ParallelAnimation { | ||
| 245 | NumberAnimation { | ||||
| 246 | target: mainStack | ||||
| 247 | property: "y" | ||||
| 248 | duration: units.longDuration | ||||
| 249 | easing.type: Easing.InOutQuad | ||||
| 250 | } | ||||
| 251 | NumberAnimation { | ||||
| 252 | target: inputPanel | ||||
| 253 | property: "y" | ||||
| 254 | duration: units.longDuration | ||||
| 255 | easing.type: Easing.OutQuad | ||||
| 256 | } | ||||
| 257 | OpacityAnimator { | ||||
| 258 | target: inputPanel | ||||
| 259 | duration: units.longDuration | ||||
| 260 | easing.type: Easing.OutQuad | ||||
| 261 | } | ||||
| 203 | } | 262 | } | ||
| 204 | } | 263 | } | ||
| 264 | }, | ||||
| 265 | Transition { | ||||
| 266 | from: "visible" | ||||
| 267 | to: "hidden" | ||||
| 268 | SequentialAnimation { | ||||
| 269 | ParallelAnimation { | ||||
| 270 | NumberAnimation { | ||||
| 271 | target: mainStack | ||||
| 272 | property: "y" | ||||
| 273 | duration: units.longDuration | ||||
| 274 | easing.type: Easing.InOutQuad | ||||
| 275 | } | ||||
| 276 | NumberAnimation { | ||||
| 277 | target: inputPanel | ||||
| 278 | property: "y" | ||||
| 279 | duration: units.longDuration | ||||
| 280 | easing.type: Easing.InQuad | ||||
| 281 | } | ||||
| 282 | OpacityAnimator { | ||||
| 283 | target: inputPanel | ||||
| 284 | duration: units.longDuration | ||||
| 285 | easing.type: Easing.InQuad | ||||
| 286 | } | ||||
| 287 | } | ||||
| 288 | ScriptAction { | ||||
| 289 | script: { | ||||
| 290 | Qt.inputMethod.hide(); | ||||
| 291 | inputPanel.item.active = false; | ||||
note that the previous code did not set the active to false. The idea was that once you activated the virtual keyboard, clicking/touching into the password field also activates if. For that the inputPanel needs to be active. In summary: if you thought I just had forgotten to set it to false, nope, it was intended ;-) graesslin: note that the previous code did not set the active to false. The idea was that once you… | |||||
| 292 | } | ||||
| 293 | } | ||||
| 294 | } | ||||
| 295 | } | ||||
| 296 | ] | ||||
| 297 | } | ||||
| 205 | 298 | | |||
| 206 | Component { | 299 | Component { | ||
| 207 | id: switchSessionPage | 300 | id: switchSessionPage | ||
| 208 | SessionManagementScreen { | 301 | SessionManagementScreen { | ||
| 209 | property var switchSession: finalSwitchSession | 302 | property var switchSession: finalSwitchSession | ||
| 210 | 303 | | |||
| 211 | Stack.onStatusChanged: { | 304 | Stack.onStatusChanged: { | ||
| 212 | if (Stack.status == Stack.Activating) { | 305 | if (Stack.status == Stack.Activating) { | ||
| ▲ Show 20 Lines • Show All 55 Lines • ▼ Show 20 Line(s) | 358 | anchors { | |||
| 268 | right: parent.right | 361 | right: parent.right | ||
| 269 | margins: units.smallSpacing | 362 | margins: units.smallSpacing | ||
| 270 | } | 363 | } | ||
| 271 | 364 | | |||
| 272 | PlasmaComponents.ToolButton { | 365 | PlasmaComponents.ToolButton { | ||
| 273 | text: i18ndc("plasma_lookandfeel_org.kde.lookandfeel", "Button to show/hide virtual keyboard", "Virtual Keyboard") | 366 | text: i18ndc("plasma_lookandfeel_org.kde.lookandfeel", "Button to show/hide virtual keyboard", "Virtual Keyboard") | ||
| 274 | iconName: inputPanel.keyboardActive ? "input-keyboard-virtual-on" : "input-keyboard-virtual-off" | 367 | iconName: inputPanel.keyboardActive ? "input-keyboard-virtual-on" : "input-keyboard-virtual-off" | ||
| 275 | onClicked: inputPanel.showHide() | 368 | onClicked: inputPanel.showHide() | ||
| 369 | | ||||
| 370 | visible: inputPanel.status == Loader.Ready | ||||
| 276 | } | 371 | } | ||
| 277 | 372 | | |||
| 278 | KeyboardLayoutButton { | 373 | KeyboardLayoutButton { | ||
| 279 | } | 374 | } | ||
| 280 | 375 | | |||
| 281 | Item { | 376 | Item { | ||
| 282 | Layout.fillWidth: true | 377 | Layout.fillWidth: true | ||
| 283 | } | 378 | } | ||
| Show All 13 Lines | |||||
Why the change to MouseArea?