Differential D4095 Diff 12149 projectmanagers/cmake/tests/testhelpers.h

Changeset View

Standalone View

View Options

projectmanagers/cmake/tests/testhelpers.h

Show First 20 Lines • Show All 126 Lines • ▼ Show 20 Line(s)123{
127 defaultConfigure(paths); 127​ defaultConfigure(paths);
128 128​
129 QSignalSpy spy(KDevelop::ICore::self()->projectController(), 129​ QSignalSpy spy(KDevelop::ICore::self()->projectController(),
130 SIGNAL(projectOpened(KDevelop::IProject*))); 130​ SIGNAL(projectOpened(KDevelop::IProject*)));
131 Q_ASSERT(spy.isValid()); 131​ Q_ASSERT(spy.isValid());
132 132​
133 KDevelop::ICore::self()->projectController()->openProject(paths.projectFile.toUrl()); 133​ KDevelop::ICore::self()->projectController()->openProject(paths.projectFile.toUrl());
134 134​
135 if ( spy.isEmpty() && !spy.wait(30000) ) 135​ if ( spy.isEmpty() && !spy.wait(30000) ) {
136 qFatal( "Timeout while waiting for opened signal" ); 136​ qFatal( "Timeout while waiting for opened signal" );
137​ }
kfunkUnsubmitted
Done

Redundant (qFatal aborts already?)

kfunk: Redundant (qFatal aborts already?)
apolAuthorUnsubmitted
Not Done

I'm never sure. I spent some time going crazy over why it didn't work, possibly that's why.

apol: I'm never sure. I spent some time going crazy over why it didn't work, possibly that's why.
137 138​
138 KDevelop::IProject* project = KDevelop::ICore::self()->projectController()->findProjectByName(name); 139​ KDevelop::IProject* project = KDevelop::ICore::self()->projectController()->findProjectByName(name);
139 Q_ASSERT(project); 140​ Q_ASSERT(project);
140 Q_ASSERT(project->buildSystemManager()); 141​ Q_ASSERT(project->buildSystemManager());
141 Q_ASSERT(paths.projectFile == project->projectFile()); 142​ Q_ASSERT(paths.projectFile == project->projectFile());
142 return project; 143​ return project;
143} 144​}
144 145​
145#endif 146​#endif