Differential D4929 Diff 12148 drkonqi/drkonqibackends.cpp

Changeset View

Standalone View

View Options

drkonqi/drkonqibackends.cpp

Context not available.
36#include "backtracegenerator.h" 36​#include "backtracegenerator.h"
37#include "drkonqi.h" 37​#include "drkonqi.h"
38 38​
39​#ifdef Q_OS_MACOS
40​#include <AvailabilityMacros.h>
41​#endif
42​
39AbstractDrKonqiBackend::~AbstractDrKonqiBackend() 43​AbstractDrKonqiBackend::~AbstractDrKonqiBackend()
40{ 44​{
41} 45​}
Context not available.
158{ 162​{
159 QList<Debugger> internalDebuggers = Debugger::availableInternalDebuggers(QStringLiteral("KCrash")); 163​ QList<Debugger> internalDebuggers = Debugger::availableInternalDebuggers(QStringLiteral("KCrash"));
160 KConfigGroup config(KSharedConfig::openConfig(), "DrKonqi"); 164​ KConfigGroup config(KSharedConfig::openConfig(), "DrKonqi");
161#ifndef Q_OS_WIN 165​#if defined(__MAC_OS_X_VERSION_MAX_ALLOWED) && __MAC_OS_X_VERSION_MAX_ALLOWED > 1070
kfunkUnsubmitted
Done

Why these special conditions? Needs comments.

Whether to use or not to use lldb on a particular OS X version should be runtime decision, too.

kfunk: Why these special conditions? Needs comments. Whether to use or not to use lldb on a…
rjvbbAuthorUnsubmitted
Done

Actually, there can be a runtime decision to use lldb on earlier (10.7-) versions but not on later versions. Gdb doesn't work properly from 10.8 onwards. And to be honest lldb was in such an early stage in 10.7 and earlier that you wouldn't want to use the system version there.
Given that gdb still works there it seems unnecessarily complicated to make this a runtime decision. Esp. since using gdb means you get access to the standard backtrace parser.

I'll put a concise version of this explanation as a comment.

rjvbb: Actually, there can be a runtime decision to use lldb on earlier (10.7-) versions but not on…
166​ QString defaultDebuggerName = config.readEntry("Debugger", QString("lldb"));
167​#elif !defined(Q_OS_WIN)
162 QString defaultDebuggerName = config.readEntry("Debugger", QStringLiteral("gdb")); 168​ QString defaultDebuggerName = config.readEntry("Debugger", QStringLiteral("gdb"));
163#else 169​#else
164 QString defaultDebuggerName = config.readEntry("Debugger", QString("kdbgwin")); 170​ QString defaultDebuggerName = config.readEntry("Debugger", QString("kdbgwin"));
Context not available.