Differential D4803 Diff 11996 src/quick/AlternativesView.qml

Changeset View

Standalone View

View Options

src/quick/AlternativesView.qml

Context not available.
19import QtQuick.Layouts 1.1 19​import QtQuick.Layouts 1.1
20import QtQuick.Controls 1.2 20​import QtQuick.Controls 1.2
21import org.kde.purpose 1.0 21​import org.kde.purpose 1.0
22​import org.kde.plasma.components 2.0 as PlasmaComponents
22 23​
23StackView { 24​StackView {
24 id: stack 25​ id: stack
26​ focus: true
25 property bool running: false 27​ property bool running: false
26 property alias pluginType: altsModel.pluginType 28​ property alias pluginType: altsModel.pluginType
27 property alias inputData: altsModel.inputData 29​ property alias inputData: altsModel.inputData
Context not available.
37 text: i18n("Use") 39​ text: i18n("Use")
38 onClicked: createJob(index); 40​ onClicked: createJob(index);
39 } 41​ }
42​ Keys.onReturnPressed: createJob(index)
43​ Keys.onEnterPressed: createJob(index)
40 } 44​ }
41 } 45​ }
42 46​
Context not available.
90 } 94​ }
91 95​
92 initialItem: ScrollView { 96​ initialItem: ScrollView {
97​ focus: true
93 ListView { 98​ ListView {
99​ focus: true
94 model: altsModel 100​ model: altsModel
101​
martUnsubmitted
Done

this should be a PlasmaComponents.Highlight instead

mart: this should be a PlasmaComponents.Highlight instead
yuenlimAuthorUnsubmitted
Not Done

after discussion, should avoid using Plasma-specific components here (in purpose) for now. To use Rectangle without custom radius instead.

yuenlim: after discussion, should avoid using Plasma-specific components here (in purpose) for now. To…
apolUnsubmitted
Done

That doesn't make sense, this is not Purpose code, this is the plasmoid. This should use Highlight as Marco suggested.

apol: That doesn't make sense, this is not Purpose code, this is the plasmoid. This should use…
95 delegate: stack.delegate 102​ delegate: stack.delegate
103​ highlight: PlasmaComponents.Highlight {}
96 } 104​ }
97 } 105​ }
98 106​
Context not available.