Differential D4776 Diff 11993 duchain/builders/declarationbuilder.cpp

Changeset View

Standalone View

View Options

duchain/builders/declarationbuilder.cpp

Context not available.
937 if ( identifier == thisQId 937​ if ( identifier == thisQId
938 && currentContext()->parentContext() 938​ && currentContext()->parentContext()
939 && currentContext()->parentContext()->type() == DUContext::Class ) { 939​ && currentContext()->parentContext()->type() == DUContext::Class ) {
940​
941​ // checks if imports \ArrayAccess
942​ ClassDeclaration* currentClass = dynamic_cast<ClassDeclaration*>(currentContext()->parentContext()->owner());
943​ ClassDeclaration* arrayAccess = nullptr;
944​
945​ auto imports = currentContext()->parentContext()->importedParentContexts();
946​ for( const DUContext::Import& ctx : imports ) {
947​ DUContext* import = ctx.context(topContext());
948​ if(import->type() == DUContext::Class) {
949​ ClassDeclaration* importedClass = dynamic_cast<ClassDeclaration*>(import->owner());
950​ if(importedClass) {
951​ if(importedClass->prettyName().str() == "ArrayAccess" && importedClass->classType() == ClassDeclarationData::ClassType::Interface && !import->parentContext()->owner()) {
952​ arrayAccess = importedClass;
953​ }
954​ }
955​ }
956​ }
957​
958​ IntegralType* thisVar = static_cast<IntegralType*>(type.data());
959​ // check if this is used as array
960​ if(arrayAccess && currentClass && thisVar && thisVar->dataType() == AbstractType::TypeArray)
961​ {
962​ uint noOfFunc = 0;
963​ auto declarations = currentContext()->parentContext()->localDeclarations();
964​ // check if class implements all 4 functions
965​ for(auto &dec : declarations) {
966​ if(dec->isFunctionDeclaration()) {
967​ QualifiedIdentifier func = dec->qualifiedIdentifier();
968​ QString funcname = func.last().identifier().str();
969​ if(funcname == "offsetexists" || funcname == "offsetget" || funcname == "offsetset" || funcname == "offsetunset") {
970​ noOfFunc++;
971​ }
972​ }
zhigalinUnsubmitted
Done

You should sleep more I think

zhigalin: You should sleep more I think
973​ }
zhigalinUnsubmitted
Done

style issue: braces are needed even for one-line statements

zhigalin: style issue: braces are needed even for one-line statements
974​
975​ if(noOfFunc < 4) {
976​ // check if class is not abstract
977​ if(currentClass->classModifier() != ClassDeclarationData::ClassModifier::Abstract) {
978​ reportError(i18n("Class %1 contains %2 abstract methods and must therefore be declared abstract or implement the remaining methods.",currentClass->prettyName().str(),4-noOfFunc), QList<AstNode*>() << node);
979​ }
980​ }
981​
982​ return;
983​ }
984​
940 reportError(i18n("Cannot re-assign $this."), QList<AstNode*>() << node); 985​ reportError(i18n("Cannot re-assign $this."), QList<AstNode*>() << node);
941 return; 986​ return;
942 } 987​ }
Context not available.