Differential D4847 Diff 11991 src/buffer/katetextbuffer_secure.cpp

Changeset View

Standalone View

src/buffer/katetextbuffer_secure.cpp

This file was added.

1		#include "katetextbuffer_secure.h"
	dhaumannUnsubmitted Not Done I would prefer katesecuretextbuffer.h as filename. Intermixing underscrores is rather uncommon in KDE's sources. dhaumann: I would prefer katesecuretextbuffer.h as filename. Intermixing underscrores is rather uncommon…
2		#include "katetextline.h"
3
4		#ifndef Q_OS_WIN
5		#include <unistd.h>
6
7		// needed for umask application
8		#include <sys/types.h>
9		#include <sys/stat.h>
10		#endif
11
12		//#include <KArchive>
13		#include <KFilterDev>
14		#include <QSaveFile>
15		#include <QObject>
16		#include <QString>
17		#include <QVariant>
18		#include <QTextCodec>
19		#include <QTextStream>
20		#include <QFile>
21
22		KAUTH_HELPER_MAIN("org.kde.ktexteditor.katetextbuffer", TextBufferSecure)
23
24		ActionReply TextBufferSecure::save(const QVariantMap& args)
25		{
26		QString filename = args[QLatin1String("filename")].toString();
27		QString mimeTypeForFilterDev = args[QLatin1String("mimeTypeForFilterDev")].toString();
28		QString textCodec = args[QLatin1String("textCodec")].toString();
29		bool generateByteOrderMark = args[QLatin1String("generateByteOrderMark")].toBool();
30		int endOfLineMode = args[QLatin1String("endOfLineMode")].toInt();
31		bool newLineAtEof = args[QLatin1String("newLineAtEof")].toBool();
	dhaumannUnsubmitted Not Done Please prepend 'const' for all local variables whenever possible. dhaumann: Please prepend 'const' for all local variables whenever possible.
32		QList<QVariant> dataToSave = args[QLatin1String("dataToSave")].toList();
33
34		bool ok = saveInternal(filename, mimeTypeForFilterDev, textCodec, generateByteOrderMark, endOfLineMode, newLineAtEof, dataToSave);
	dhaumannUnsubmitted Not Done const bool ok = ... dhaumann: const bool ok = ...
35
36		return ok ? ActionReply::SuccessReply() : ActionReply::HelperErrorReply();
37		}
38
39		bool TextBufferSecure::saveInternal(const QString &filename, const QString &mimeTypeForFilterDev, const QString &textCodec,
40		const bool &generateByteOrderMark, const int &endOfLineMode, const bool &newLineAtEof, const QList<QVariant> &dataToSave)
41		{
42		#ifndef Q_OS_WIN
43		const bool newFile = !QFile::exists(filename);
44		#endif
45
46		/**
47		* use QSaveFile for save write + rename
48		*/
49		QSaveFile saveFile(filename);
50		saveFile.setDirectWriteFallback(true);
51
52		if (!saveFile.open(QIODevice::WriteOnly \| QIODevice::Truncate)) {
53		return false;
54		}
55
56		/**
57		* construct correct filter device and try to open
58		*/
59		KCompressionDevice::CompressionType type = KFilterDev::compressionTypeForMimeType(mimeTypeForFilterDev);
60		KCompressionDevice file(&saveFile, false, type);
61
62		if (!file.open(QIODevice::WriteOnly)) {
63		return false;
64		}
65
66		/**
67		* construct stream + disable Unicode headers
68		*/
69		QTextStream stream(&file);
70		stream.setCodec(QTextCodec::codecForName("UTF-16"));
71
72		// set the correct codec
73		stream.setCodec(QTextCodec::codecForName(textCodec.toLatin1()));
74
75		// generate byte order mark?
76		stream.setGenerateByteOrderMark(generateByteOrderMark);
77
78		// our loved eol string ;)
79		QString eol = QStringLiteral("\n"); //m_doc->config()->eolString ();
80		if (endOfLineMode == 1) {
81		eol = QStringLiteral("\r\n");
82		} else if (endOfLineMode == 2) {
83		eol = QStringLiteral("\r");
84		}
85
86		// just dump the lines out ;)
87		int lineCount = dataToSave.count();
	dhaumannUnsubmitted Not Done const int lineCount = ... dhaumann: const int lineCount = ...
88		for (int i = 0; i < lineCount; ++i) {
89		// get line to save
90		Kate::TextLine textline(new Kate::TextLineData(dataToSave[i].toString()));
91
92		stream << textline->text();
93
94		// append correct end of line string
95		if ((i + 1) < lineCount) {
96		stream << eol;
97		}
98		}
99
100		if (newLineAtEof) {
101		Q_ASSERT(lineCount > 0); // see .h file
102		Kate::TextLine lastLine(new Kate::TextLineData(dataToSave[lineCount - 1].toString()));
103		const int firstChar = lastLine->firstChar();
104		if (firstChar > -1 \|\| lastLine->length() > 0) {
105		stream << eol;
106		}
107		}
108
109		// flush stream
110		stream.flush();
111
112		// close and delete file
113		file.close();
114
115		// flush file
116		if (!saveFile.flush()) {
117		return false;
118		}
119
120		#ifndef Q_OS_WIN
121		// ensure that the file is written to disk
122		#ifdef HAVE_FDATASYNC
123		fdatasync(saveFile.handle());
124		#else
125		fsync(saveFile.handle());
126		#endif
127		#endif
128
129		// did save work?
130		// only finalize if stream status == OK
131		bool ok = (stream.status() == QTextStream::Ok) && saveFile.commit();
132
133		#ifndef Q_OS_WIN
134		if (ok && newFile) { // QTemporaryFile sets permissions to 0600, so fixing this
135		const mode_t mask = umask(0);
136		umask(mask);
137
138		const mode_t fileMode = 0666 & ~mask;
139		chmod(QFile::encodeName(filename).constData(), fileMode);
140		}
141		#endif
142
143		return ok;
144		}