Differential D4847 Diff 11990 src/buffer/katetextbuffer_secure.h

Changeset View

Standalone View

1		#ifndef KATE_TEXTBUFFER_SECURE_H
2		#define KATE_TEXTBUFFER_SECURE_H
3
4		#include <QObject>
5		#include <QString>
6		#include <QVariant>
7
8		#include <kauth.h>
9
10		using namespace KAuth;
11
	dhaumannUnsubmitted Not Done Please no using namespace KAuth here, especially since this is a header file. dhaumann: Please no using namespace KAuth here, especially since this is a header file.
12		class TextBufferSecure : public QObject
13		{
	dhaumannUnsubmitted Not Done Please call it SecureTextBuffer, that feels much more natural than adding the suffix "Secure". dhaumann: Please call it SecureTextBuffer, that feels much more natural than adding the suffix "Secure".
14		Q_OBJECT
15
16		public:
17
18		TextBufferSecure() {};
19
	dhaumannUnsubmitted Not Done Pedantic: no semicolon after a closing function brace, i.e.: SecureTextBuffer() {} dhaumann: Pedantic: no semicolon after a closing function brace, i.e.: SecureTextBuffer() {}
20		~TextBufferSecure() {};
21
22		bool saveInternal(const QString &filename, const QString &mimeTypeForFilterDev, const QString &textCodec, const bool &generateByteOrderMark,
23		const int &endOfLineMode, const bool &newLineAtEof, const QList<QVariant> &dataToWrite);
	dhaumannUnsubmitted Not Done Please never use const references for primitive types. Here: const bool & --> bool dhaumann: Please never use const references for primitive types. Here: - const bool & --> bool
24
25		public Q_SLOTS:
26		ActionReply save(const QVariantMap &args);
27
28		};
29
30		#endif