Differential D4776 Diff 11970 duchain/tests/duchain.cpp

Changeset View

Standalone View

View Options

duchain/tests/duchain.cpp

Context not available.
2954 QCOMPARE(top->problems().at(1)->description(), QString("FIXME blub")); 2954​ QCOMPARE(top->problems().at(1)->description(), QString("FIXME blub"));
2955 QCOMPARE(top->problems().at(1)->range(), RangeInRevision(2, 4, 2, 14)); 2955​ QCOMPARE(top->problems().at(1)->range(), RangeInRevision(2, 4, 2, 14));
2956} 2956​}
2957​
2958​void TestDUChain::useThisAsArray()
2959​{
2960​ QByteArray method("<?php\n"
zhigalinUnsubmitted
Done

Just prepend arrayaccess here

zhigalin: Just prepend arrayaccess here
2961​ " class SHASHWAT extends \\ArrayAccess\n"
zhigalinUnsubmitted
Done

implements

zhigalin: implements
2962​ " {\n"
2963​ " $values = [];\n"
2964​ " function offsetGet($offset) { return $this->values[$offset]; }\n"
2965​ " function offsetSet($offset, $value) { $this->values[$offset] = $value; }\n"
2966​ " function offsetExists($offset) { return array_key_exists($offset, $this->values); }\n"
2967​ " function offsetUnset($offset) { unset($this->values[$offset]); }\n"
2968​ " function setTest() { $this['test'] = 'test'; } \n"
2969​ " }\n"
2970​ " $test = new SHASHWAT;\n"
2971​ " $test->setTest();\n"
2972​ " echo $test['test'];\n");
zhigalinUnsubmitted
Done

no need

zhigalin: no need
2973​
2974​ TopDUContext* top = parse(method);
2975​ QVERIFY(top);
2976​ DUChainReleaser releaseTop(top);
2977​ DUChainWriteLocker lock(DUChain::lock());
2978​
2979​ QCOMPARE(top->importedParentContexts().count(), 1);
2980​ QVERIFY(DUChain::self()->chainForDocument(internalFunctionFile()));
2981​ QCOMPARE(DUChain::self()->chainForDocument(internalFunctionFile()), top->importedParentContexts().first().context(top));
2982​
2983​ QVERIFY(top->problems().isEmpty());
2984​}
2985​
2986​void TestDUChain::wrongUseOfThisAsArray()
2987​{
2988​ // missing functions from \ArrayAccess and not declared abstract
2989​ QByteArray method("<?php\n"
zhigalinUnsubmitted
Done

Just prepend arrayaccess here

zhigalin: Just prepend arrayaccess here
2990​ " class A\n"
zhigalinUnsubmitted
Done

class A implements ArrayAccess

zhigalin: class A implements ArrayAccess
2991​ " {\n"
2992​ " public function setTest() { $this['test'] = 'test'; } \n"
2993​ " }\n"
2994​ " $test = new A;\n"
2995​ " $test->setTest();\n"
2996​ " echo $test['test'];\n");
zhigalinUnsubmitted
Done

no need

zhigalin: no need
2997​
2998​ TopDUContext* top = parse(method);
2999​ QVERIFY(top);
3000​ DUChainReleaser releaseTop(top);
3001​ DUChainWriteLocker lock(DUChain::lock());
3002​
3003​ QCOMPARE(top->problems().size(),1);
3004​}
Context not available.