Differential D4776 Diff 11970 duchain/builders/declarationbuilder.cpp

Changeset View

Standalone View

View Options

duchain/builders/declarationbuilder.cpp

Context not available.
937 if ( identifier == thisQId 937​ if ( identifier == thisQId
938 && currentContext()->parentContext() 938​ && currentContext()->parentContext()
939 && currentContext()->parentContext()->type() == DUContext::Class ) { 939​ && currentContext()->parentContext()->type() == DUContext::Class ) {
940​
941​ // checks if imports \ArrayAccess
942​ ClassDeclaration* currentClass = dynamic_cast<ClassDeclaration*>(currentContext()->parentContext()->owner());
943​ ClassDeclaration* arrayAccess = nullptr;
944​
945​ auto imports = currentContext()->parentContext()->importedParentContexts();
946​ for( const DUContext::Import& ctx : imports ) {
947​ DUContext* import = ctx.context(topContext());
948​ if(import->type() == DUContext::Class)
949​ {
950​ ClassDeclaration* importedClass = dynamic_cast<ClassDeclaration*>(import->owner());
951​ if(importedClass)
952​ if(importedClass->prettyName().str() == "ArrayAccess" && importedClass->classType() == ClassDeclarationData::ClassType::Interface && !import->parentContext()->owner())
953​ {
954​ arrayAccess = importedClass;
955​ }
956​ }
957​ }
958​
959​ IntegralType* thisVar = static_cast<IntegralType*>(type.data());
960​ // check if this is used as array
961​ if(arrayAccess && currentClass && thisVar && thisVar->dataType() == AbstractType::TypeArray)
962​ {
963​ uint noOfFunc = 0;
964​ auto declarations = currentContext()->parentContext()->localDeclarations();
965​ // check if class implements all 4 functions
966​ for(auto &dec : declarations)
967​ {
968​ if(dec->isFunctionDeclaration())
969​ {
970​ QualifiedIdentifier func = dec->qualifiedIdentifier();
971​ QString funcname = func.last().identifier().str();
972​ if(funcname == "offsetexists" || funcname == "offsetget" || funcname == "offsetset" || funcname == offsetunset")
zhigalinUnsubmitted
Done

You should sleep more I think

zhigalin: You should sleep more I think
973​ noOfFunc++;
zhigalinUnsubmitted
Done

style issue: braces are needed even for one-line statements

zhigalin: style issue: braces are needed even for one-line statements
974​ }
975​ }
976​
977​ if(noOfFunc < 4)
978​ {
979​ // check if class is not abstract
980​ if(currentClass->classModifier() != ClassDeclarationData::ClassModifier::Abstract)
981​ reportError(i18n("Class %1 contains %2 abstract methods and must therefore be declared abstract or implement the remaining methods.",currentClass->prettyName().str(),4-noOfFunc), QList<AstNode*>() << node);
982​ }
983​
984​ return;
985​ }
986​
940 reportError(i18n("Cannot re-assign $this."), QList<AstNode*>() << node); 987​ reportError(i18n("Cannot re-assign $this."), QList<AstNode*>() << node);
941 return; 988​ return;
942 } 989​ }
Context not available.