Differential D4690 Diff 11620 src/ioslaves/remote/remoteimpl.cpp

Changeset View

Standalone View

View Options

src/ioslaves/remote/remoteimpl.cpp

  • This file was added.
1​/* This file is part of the KDE project
2​ Copyright (c) 2004 Kevin Ottens <ervin ipsquad net>
3​
4​ This library is free software; you can redistribute it and/or
5​ modify it under the terms of the GNU Library General Public
6​ License as published by the Free Software Foundation; either
7​ version 2 of the License, or (at your option) any later version.
8​
9​ This library is distributed in the hope that it will be useful,
10​ but WITHOUT ANY WARRANTY; without even the implied warranty of
11​ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
12​ Library General Public License for more details.
13​
14​ You should have received a copy of the GNU Library General Public License
15​ along with this library; see the file COPYING.LIB. If not, write to
16​ the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
17​ Boston, MA 02110-1301, USA.
18​*/
19​
20​#include "remoteimpl.h"
21​
22​#include "debug.h"
23​#include <KConfigGroup>
24​#include <KDesktopFile>
25​#include <KLocalizedString>
26​#include <KService>
27​
28​#include <QDir>
29​#include <QFile>
30​
31​#define WIZARD_URL "remote:/x-wizard_service.desktop"
32​#define WIZARD_SERVICE "org.kde.knetattach"
dfaureUnsubmitted
Not Done

probably unused at this point

dfaure: probably unused at this point
33​
34​RemoteImpl::RemoteImpl()
35​{
36​ const QString path = QStringLiteral("%1/remoteview").arg(QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation));
37​ QDir().mkpath(path);
38​}
39​
40​void RemoteImpl::listRoot(KIO::UDSEntryList &list) const
41​{
42​ qCDebug(KIOREMOTE_LOG) << "RemoteImpl::listRoot";
43​
dfaureUnsubmitted
Done

This should probably be QDir().mkpath(path) instead of the whole if exists + cdUp + mkdir dance, which would fail if the parent doesn't exist either (ok, unlikely, but anyway, mkpath is shorter and safer)

dfaure: This should probably be QDir().mkpath(path) instead of the whole if exists + cdUp + mkdir dance…
44​ QStringList names_found;
45​ const QStringList dirList = QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, QStringLiteral("remoteview"),
46​ QStandardPaths::LocateDirectory);
47​
48​ QStringList::ConstIterator dirpath = dirList.constBegin();
49​ const QStringList::ConstIterator end = dirList.constEnd();
50​ for (; dirpath != end; ++dirpath) {
51​ QDir dir = *dirpath;
52​ if (!dir.exists()) {
53​ continue;
54​ }
55​
56​ const QStringList filenames = dir.entryList(QDir::Files | QDir::Readable);
57​
58​ KIO::UDSEntry entry;
59​
60​ QStringList::ConstIterator name = filenames.constBegin();
61​ QStringList::ConstIterator endf = filenames.constEnd();
62​
63​ for (; name != endf; ++name) {
64​ if (!names_found.contains(*name)) {
65​ entry.clear();
66​ createEntry(entry, *dirpath, *name);
67​ list.append(entry);
68​ names_found.append(*name);
69​ }
70​ }
71​ }
72​}
73​
74​bool RemoteImpl::findDirectory(const QString &filename, QString &directory) const
75​{
76​ qCDebug(KIOREMOTE_LOG) << "RemoteImpl::findDirectory";
77​
78​ const QStringList dirList = QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, QStringLiteral("remoteview"),
79​ QStandardPaths::LocateDirectory);
80​
81​ QStringList::ConstIterator dirpath = dirList.constBegin();
82​ const QStringList::ConstIterator end = dirList.constEnd();
83​ for (; dirpath != end; ++dirpath) {
84​ if (QFileInfo::exists(*dirpath + QLatin1Char('/') + filename)) {
85​ directory = *dirpath + QLatin1Char('/');
86​ return true;
87​ }
88​ }
dfaureUnsubmitted
Not Done

The QDir object and this check are now redundant. It's all covered by the QFileInfo::exists check below.

dfaure: The QDir object and this check are now redundant. It's all covered by the QFileInfo::exists…
89​
90​ return false;
91​}
92​
93​QString RemoteImpl::findDesktopFile(const QString &filename) const
94​{
95​ qCDebug(KIOREMOTE_LOG) << "RemoteImpl::findDesktopFile";
96​
97​ QString directory;
dfaureUnsubmitted
Done

Wow this is convoluted, a simple QFile::exists(*dirpath + '/' + filename) should be enough rather than a full directory listing.

dfaure: Wow this is convoluted, a simple QFile::exists(*dirpath + '/' + filename) should be enough…
98​ if (findDirectory(filename+".desktop", directory)) {
99​ return directory+filename+".desktop";
100​ }
101​
102​ return QString();
103​}
104​
105​QUrl RemoteImpl::findBaseURL(const QString &filename) const
106​{
107​ qCDebug(KIOREMOTE_LOG) << "RemoteImpl::findBaseURL";
108​
109​ const QString file = findDesktopFile(filename);
110​ if (!file.isEmpty()) {
111​ KDesktopFile desktop(file);
112​ return QUrl::fromUserInput(desktop.readUrl());
113​ }
114​
115​ return QUrl();
116​}
117​
118​void RemoteImpl::createTopLevelEntry(KIO::UDSEntry &entry) const
119​{
120​ entry.clear();
121​ entry.insert(KIO::UDSEntry::UDS_NAME, QString::fromLatin1("."));
122​ entry.insert(KIO::UDSEntry::UDS_FILE_TYPE, S_IFDIR);
123​ entry.insert(KIO::UDSEntry::UDS_ACCESS, 0777);
124​ entry.insert(KIO::UDSEntry::UDS_MIME_TYPE, QString::fromLatin1("inode/directory"));
125​ entry.insert(KIO::UDSEntry::UDS_ICON_NAME, QString::fromLatin1("folder-remote"));
126​ entry.insert(KIO::UDSEntry::UDS_USER, QString::fromLatin1("root"));
127​ entry.insert(KIO::UDSEntry::UDS_GROUP, QString::fromLatin1("root"));
128​}
129​
130​static QUrl findWizardRealURL()
131​{
132​ QUrl url;
133​ KService::Ptr service = KService::serviceByDesktopName(WIZARD_SERVICE);
134​
135​ if (service && service->isValid()) {
136​ url = QUrl::fromLocalFile(QStandardPaths::locate(QStandardPaths::ApplicationsLocation,
137​ QStringLiteral("%1.desktop").arg(WIZARD_SERVICE)));
138​ }
139​
140​ return url;
141​}
142​
143​bool RemoteImpl::createWizardEntry(KIO::UDSEntry &entry) const
144​{
145​ entry.clear();
146​
147​ QUrl url = findWizardRealURL();
148​
149​ if (!url.isValid()) {
150​ return false;
151​ }
152​
153​ entry.insert(KIO::UDSEntry::UDS_NAME, i18n("Add Network Folder"));
154​ entry.insert(KIO::UDSEntry::UDS_FILE_TYPE, S_IFREG);
155​ entry.insert(KIO::UDSEntry::UDS_URL, QString::fromLatin1(WIZARD_URL));
156​ entry.insert(KIO::UDSEntry::UDS_LOCAL_PATH, url.path());
dfaureUnsubmitted
Not Done

wrong port to QUrl, should be url = QUrl::fromLocalFile(...)

dfaure: wrong port to QUrl, should be url = QUrl::fromLocalFile(...)
157​ entry.insert(KIO::UDSEntry::UDS_ACCESS, 0500);
158​ entry.insert(KIO::UDSEntry::UDS_MIME_TYPE, QString::fromLatin1("application/x-desktop"));
159​ entry.insert(KIO::UDSEntry::UDS_ICON_NAME, QString::fromLatin1("folder-new"));
160​
161​ return true;
162​}
163​
164​bool RemoteImpl::isWizardURL(const QUrl &url) const
165​{
166​ return url == QUrl(WIZARD_URL);
167​}
168​
169​void RemoteImpl::createEntry(KIO::UDSEntry &entry, const QString &directory,
170​ const QString &file) const
171​{
172​ qCDebug(KIOREMOTE_LOG) << "RemoteImpl::createEntry";
173​
174​ QString dir = directory;
175​ if (!dir.endsWith(QLatin1Char('/'))) {
176​ dir += QLatin1Char('/');
177​ }
178​ KDesktopFile desktop(dir + file);
179​
180​ qCDebug(KIOREMOTE_LOG) << "path = " << directory << file;
181​
182​ entry.clear();
183​
184​ QString new_filename = file;
185​ new_filename.truncate(file.length()-8);
186​
187​ entry.insert(KIO::UDSEntry::UDS_NAME, desktop.readName());
188​ entry.insert(KIO::UDSEntry::UDS_URL, "remote:/"+new_filename);
189​
190​ entry.insert(KIO::UDSEntry::UDS_FILE_TYPE, S_IFDIR);
191​ entry.insert(KIO::UDSEntry::UDS_ACCESS, 0500);
192​ entry.insert(KIO::UDSEntry::UDS_MIME_TYPE, QString::fromLatin1("inode/directory"));
193​
194​ const QString icon = desktop.readIcon();
195​ entry.insert(KIO::UDSEntry::UDS_ICON_NAME, icon);
196​ entry.insert(KIO::UDSEntry::UDS_LINK_DEST, desktop.readUrl());
197​ entry.insert(KIO::UDSEntry::UDS_TARGET_URL, desktop.readUrl());
198​}
199​
200​bool RemoteImpl::statNetworkFolder(KIO::UDSEntry &entry, const QString &filename) const
201​{
202​ qCDebug(KIOREMOTE_LOG) << "RemoteImpl::statNetworkFolder: " << filename;
203​
204​ QString directory;
205​ if (findDirectory(filename+".desktop", directory)) {
206​ createEntry(entry, directory, filename+".desktop");
207​ return true;
208​ }
209​
210​ return false;
211​}
212​
213​bool RemoteImpl::deleteNetworkFolder(const QString &filename) const
214​{
215​ qCDebug(KIOREMOTE_LOG) << "RemoteImpl::deleteNetworkFolder: " << filename;
216​
217​ QString directory;
218​ if (findDirectory(filename+".desktop", directory)) {
219​ qCDebug(KIOREMOTE_LOG) << "Removing " << directory << filename << ".desktop";
220​ return QFile::remove(directory+filename+".desktop");
221​ }
222​
223​ return false;
224​}
225​
226​bool RemoteImpl::renameFolders(const QString &src, const QString &dest, bool overwrite) const
227​{
228​ qCDebug(KIOREMOTE_LOG) << "RemoteImpl::renameFolders: "
229​ << src << ", " << dest << endl;
230​
231​ QString directory;
232​ if (findDirectory(src+".desktop", directory)) {
233​ if (!overwrite && QFile::exists(directory+dest+".desktop")) {
234​ return false;
235​ }
236​
237​ qCDebug(KIOREMOTE_LOG) << "Renaming " << directory << src << ".desktop";
238​ QDir dir(directory);
239​ bool res = dir.rename(src+".desktop", dest+".desktop");
240​ if (res) {
241​ KDesktopFile desktop(directory+dest+".desktop");
242​ desktop.desktopGroup().writeEntry("Name", dest);
243​ }
244​ return res;
245​ }
246​
247​ return false;
248​}
249​
250​bool RemoteImpl::changeFolderTarget(const QString &src, const QString &target, bool overwrite) const
251​{
252​ qCDebug(KIOREMOTE_LOG) << "RemoteImpl::changeFolderTarget: "
253​ << src << ", " << target << endl;
254​
255​ QString directory;
256​ if (findDirectory(src+".desktop", directory)) {
257​ if (!overwrite || !QFile::exists(directory+src+".desktop")) {
258​ return false;
259​ }
260​
261​ qCDebug(KIOREMOTE_LOG) << "Changing target " << directory << src << ".desktop";
262​ KDesktopFile desktop(directory+src+".desktop");
263​ desktop.desktopGroup().writeEntry("URL", target);
264​ return true;
265​ }
266​
267​ return false;
268​}