Differential D4483 Diff 11021 language/duchain/navigation/useswidget.cpp

Changeset View

Standalone View

View Options

language/duchain/navigation/useswidget.cpp

Context not available.
154 m_layout->setAlignment(Qt::AlignLeft); 154​ m_layout->setAlignment(Qt::AlignLeft);
155} 155​}
156 156​
157​void OneUseWidget::setHighlighted(bool highlight)
158​{
159​ if (highlight) {
160​ m_label->setText(m_label->text().replace("background-color:#fbfa96", "background-color:#fb96f2"));
mwolffUnsubmitted
Done

this is pretty brittle, please introduce free functions in an anonymous namespace that return a QColor for the active and inactive color, then use their names here. I simply guess that the hashes you use here are those of the QColors used in highlightAndEscapeUseText?

mwolff: this is pretty brittle, please introduce free functions in an anonymous namespace that return a…
161​ m_isHighlighted = true;
162​ }
mwolffUnsubmitted
Done

style: join with next line

mwolff: style: join with next line
163​ else {
164​ m_label->setText(m_label->text().replace("background-color:#fb96f2", "background-color:#fbfa96"));
165​ m_isHighlighted = false;
166​ }
167​}
168​
169​bool OneUseWidget::isHighlighted()
170​{
171​ return m_isHighlighted;
mwolffUnsubmitted
Done

maybe add this early on:

if (highlight == m_isHighlighted) {
    return;
}
mwolff: maybe add this early on: ``` if (highlight == m_isHighlighted) { return; } ```
172​}
173​
174​void OneUseWidget::activateLink()
175​{
176​ ICore::self()->documentController()->openDocument(m_document.toUrl(), m_range->range().start());
177​}
178​
157void OneUseWidget::mousePressEvent(QMouseEvent* event) 179​void OneUseWidget::mousePressEvent(QMouseEvent* event)
158{ 180​{
159 if (event->button() == Qt::LeftButton && !event->modifiers()) { 181​ if (event->button() == Qt::LeftButton && !event->modifiers()) {
160 ICore::self()->documentController()->openDocument(m_document.toUrl(), m_range->range().start()); 182​ activateLink();
161 event->accept(); 183​ event->accept();
162 } 184​ }
163} 185​}
Context not available.