Differential D4250 Diff 10738 shell/ktexteditorpluginintegration.cpp

Changeset View

Standalone View

View Options

shell/ktexteditorpluginintegration.cpp

Context not available.
38#include "plugincontroller.h" 38​#include "plugincontroller.h"
39#include "mainwindow.h" 39​#include "mainwindow.h"
40#include "textdocument.h" 40​#include "textdocument.h"
41​#include "mainwindow_p.h"
41 42​
42#include <util/objectlist.h> 43​#include <util/objectlist.h>
43 44​
brauchUnsubmitted
Not Done

Why is this required now?

brauch: Why is this required now?
head7AuthorUnsubmitted
Not Done

In ktexteditor:src/utils/mainwindow.cpp splitView() function we have

QMetaObject::invokeMethod(parent()
                          , "splitView"
                          , Qt::DirectConnection
                          , Q_ARG(Qt::Orientation, orientation));

and this function is called from AppCommands::exec (ktexteditor:src/vimode/appcommand.cpp) on the pointer mainWin:

mainWin->splitView(Qt::Horizontal);

which is view->mainWindow() (the same kteView->mainWindow() above), so in my understanding we are then calling invokemethod on kteView->mainWindow()->parent() but this pointer was a nullptr, so I set it to the "correct" mainWindow object (this) when creating the wrapped view, but it's maybee not the best way to proceed ?

head7: In ktexteditor:src/utils/mainwindow.cpp splitView() function we have QMetaObject…
mwolffUnsubmitted
Done

style: put { on its own line

mwolff: style: put { on its own line
Context not available.
349 KTextEditor::Editor::instance()->setApplication(app); 350​ KTextEditor::Editor::instance()->setApplication(app);
350} 351​}
351 352​
353​void MainWindow::splitView(Qt::Orientation orientation)
354​{
355​ m_mainWindow->d->split(orientation);
mwolffUnsubmitted
Not Done

use public API, i.e. add a void split(Qt::Orientation orientation); to MainWindow and call d->split internally. so here it's just

m_mainWindow->split(orientation);
mwolff: use public API, i.e. add a void split(Qt::Orientation orientation); to MainWindow and call d…
356​}
357​
352} 358​}
353 359​
354#include "ktexteditorpluginintegration.moc" 360​#include "ktexteditorpluginintegration.moc"
Context not available.