Differential D4334 Diff 10674 shell/debugcontroller.cpp

Changeset View

Standalone View

View Options

shell/debugcontroller.cpp

Context not available.
50#include "core.h" 50​#include "core.h"
51#include "debug.h" 51​#include "debug.h"
52#include "uicontroller.h" 52​#include "uicontroller.h"
53​#include "iruncontroller.h"
54​#include "launchconfigurationdialog.h"
53 55​
54 56​
55namespace KDevelop { 57​namespace KDevelop {
mwolffUnsubmitted
Not Done

rename to: setContinueStartsDebug

mwolff: rename to: setContinueStartsDebug
Context not available.
472 if (m_currentSession) { 474​ if (m_currentSession) {
473 m_currentSession.data()->run(); 475​ m_currentSession.data()->run();
474 } 476​ }
477​ else{
mwolffUnsubmitted
Done

join to next line, add space after else, such that it reads: } else {

mwolff: join to next line, add space after else, such that it reads: `} else {`
478​ if(ICore::self()->runController()->launchConfigurations().isEmpty()) {
mwolffUnsubmitted
Done

space after if

mwolff: space after if
479​ LaunchConfigurationDialog d;
480​ d.exec();
481​ }
482​ ICore::self()->runController()->executeDefaultLaunch(QStringLiteral("debug"));
mwolffUnsubmitted
Not Done

if the dialog gets canceled, we may still not have a launch, right? will that still work fine (i.e. no crash/warning), or should that be catched explicitly here?

mwolff: if the dialog gets canceled, we may still not have a launch, right? will that still work fine…
dporobicAuthorUnsubmitted
Not Done

A crash should not happen, further execution will be stopped here and a warning will be written to console. It's the same why how the real debug action is implemented.

void KDevelop::RunController::executeDefaultLaunch(const QString& runMode)
{
    auto dl = defaultLaunch();
    if( !dl )
    {
        qWarning() << "no default launch!";
        return;
    }
    execute( runMode, dl );
}
dporobic: A crash should not happen, further execution will be stopped here and a warning will be written…
483​ }
475} 484​}
476 485​
477void DebugController::runToCursor() { 486​void DebugController::runToCursor() {
Context not available.