Differential D4095 Diff 10471 projectmanagers/cmake/cmakeserverimportjob.cpp

Changeset View

Standalone View

View Options

projectmanagers/cmake/cmakeserverimportjob.cpp

  • This file was added.
1​/* KDevelop CMake Support
2​ *
3​ * Copyright 2017 Aleix Pol Gonzalez <aleixpol@kde.org>
4​ *
mwolffUnsubmitted
Done

really?

mwolff: really?
5​ * This program is free software; you can redistribute it and/or
6​ * modify it under the terms of the GNU General Public License
7​ * as published by the Free Software Foundation; either version 2
8​ * of the License, or (at your option) any later version.
9​ *
10​ * This program is distributed in the hope that it will be useful,
11​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
12​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13​ * GNU General Public License for more details.
14​ *
15​ * You should have received a copy of the GNU General Public License
16​ * along with this program; if not, write to the Free Software
17​ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
18​ * 02110-1301, USA.
19​ */
20​
21​#include "cmakeserverimportjob.h"
22​#include "cmakeutils.h"
23​#include "cmakeserver.h"
24​#include <interfaces/iproject.h>
25​#include <QJsonArray>
26​#include <QRegularExpression>
27​#include "debug.h"
28​#include <projectmanagers/custommake/makefileresolver/makefileresolver.h>
29​
kfunkUnsubmitted
Not Done

Style: Off in this whole file, try "Reformat source" with kdev_format script -- you'll be surprised - it works!

kfunk: Style: Off in this whole file, try "Reformat source" with kdev_format script -- you'll be…
30​template <typename T, typename Q, typename W>
31​static T kTransform(const Q& list, W func)
mwolffUnsubmitted
Not Done

you only use it with T == Path::List, so why not hardcode that?

mwolff: you only use it with T == Path::List, so why not hardcode that?
32​{
33​ T ret;
34​ ret.reserve(list.size());
35​ for (auto it = list.constBegin(), itEnd = list.constEnd(); it!=itEnd; ++it)
36​ ret += func(*it);
37​ return ret;
38​}
39​
40​static QString unescape(const QStringRef& input)
mwolffUnsubmitted
Done

please add it as a getter to the MakefileResolver API, which is used elsewhere in CMake already. That way we don't duplicate this magic

mwolff: please add it as a getter to the MakefileResolver API, which is used elsewhere in CMake already.
41​{
42​ QString output;
43​ output.reserve(input.length());
44​ bool isEscaped = false;
mwolffUnsubmitted
Not Done

QStringLiteral

mwolff: QStringLiteral
45​ for (auto it = input.data(), end = it + input.length(); it != end; ++it) {
46​ QChar c = *it;
47​ if (!isEscaped && c == '\\') {
48​ isEscaped = true;
49​ } else {
50​ output.append(c);
51​ isEscaped = false;
52​ }
53​ }
54​ return output;
55​}
56​
57​static QHash<QString, QString> processDefines(const QString &compileFlags, const QJsonArray &defines)
58​{
59​ QHash<QString, QString> ret;
60​ const auto& defineRx = MakeFileResolver::defineRegularExpression();
61​ auto it = defineRx.globalMatch(compileFlags);
62​ while (it.hasNext()) {
63​ const auto match = it.next();
64​ QString value;
65​ if (match.lastCapturedIndex() > 1) {
66​ value = unescape(match.capturedRef(match.lastCapturedIndex()));
67​ }
68​ ret[match.captured(1)] = value;
69​ }
70​
mwolffUnsubmitted
Done

this could probably be part of a helper function in the MakefileResolver (see above), since that does something like that already elsewhere, I guess?

mwolff: this could probably be part of a helper function in the MakefileResolver (see above), since…
71​ for(const QJsonValue& defineValue: defines) {
72​ const QString define = defineValue.toString();
mwolffUnsubmitted
Not Done

space after for

mwolff: space after for
73​ const int eqIdx = define.indexOf(QLatin1Char('='));
74​ if (eqIdx<0)
75​ ret[define] = QString();
mwolffUnsubmitted
Not Done

add braces and spaces around operator

mwolff: add braces and spaces around operator
76​ else
77​ ret[define.left(eqIdx)] = define.mid(eqIdx+1);
78​ }
79​ return ret;
80​}
81​
82​static void processFileData(const QJsonObject &response, CMakeProjectData &data)
83​{
84​ const auto configs = response.value(QLatin1String("configurations")).toArray();
mwolffUnsubmitted
Not Done

spaces around operators

mwolff: spaces around operators
85​ qCDebug(CMAKE) << "process response" << response;
86​ for (const auto &config: configs) {
87​ const auto projects = config.toObject().value(QLatin1String("projects")).toArray();
88​ for (const auto &project: projects) {
89​ const auto targets = project.toObject().value(QLatin1String("targets")).toArray();
90​ for (const auto &targetObject: targets) {
91​ const auto target = targetObject.toObject();
92​ const KDevelop::Path targetDir(target.value(QLatin1String("sourceDirectory")).toString());
93​
94​ data.targets[targetDir] += target.value(QLatin1String("name")).toString();
kfunkUnsubmitted
Done

How polite :)

kfunk: How polite :)
antonanikinUnsubmitted
Not Done

LOL

antonanikin: LOL
95​
96​ const auto fileGroups = target.value(QLatin1String("fileGroups")).toArray();
97​ for (const auto &fileGroupValue: fileGroups) {
98​ const auto fileGroup = fileGroupValue.toObject();
99​ CMakeFile file;
100​ file.includes = kTransform<KDevelop::Path::List>(fileGroup.value(QLatin1String("includePath")).toArray(), [](const QJsonValue& val) { return KDevelop::Path(val.toObject().value(QLatin1String("path")).toString()); });
101​ file.defines = processDefines(fileGroup.value(QLatin1String("compileFlags")).toString(), fileGroup.value(QLatin1String("defines")).toArray());
102​
103​ const auto sourcesArray = fileGroup.value(QLatin1String("sources")).toArray();
104​ const KDevelop::Path::List sources = kTransform<KDevelop::Path::List>(sourcesArray, [targetDir](const QJsonValue& val) { return KDevelop::Path(targetDir, val.toString()); });
105​ for (const auto& source: sources) {
106​ data.compilationData.files[source] = file;
107​ }
108​ qCDebug(CMAKE) << "registering..." << sources << file;
109​ }
110​ }
111​ }
112​ }
113​}
114​
115​CMakeServerImportJob::CMakeServerImportJob(KDevelop::IProject* project, CMakeServer* server, QObject* parent)
116​ : KJob(parent)
117​ , m_server(server)
118​ , m_project(project)
119​{
120​ connect(m_server, &CMakeServer::disconnected, this, [this]() {
121​ setError(UnexpectedDisconnect);
122​ emitResult();
123​ });
124​}
125​
126​void CMakeServerImportJob::start()
127​{
128​ if (m_server->isServerAvailable())
129​ doStart();
130​ else
131​ connect(m_server, &CMakeServer::connected, this, &CMakeServerImportJob::doStart);
132​}
133​
134​void CMakeServerImportJob::doStart()
135​{
136​ connect(m_server, &CMakeServer::response, this, &CMakeServerImportJob::processResponse);
137​
138​ m_server->handshake(m_project->path(), CMake::currentBuildDir(m_project));
139​}
140​
141​void CMakeServerImportJob::processResponse(const QJsonObject& response)
142​{
143​ const auto responseType = response.value(QLatin1String("type"));
144​ if (responseType == QLatin1String("reply")) {
145​ const auto inReplyTo = response.value(QLatin1String("inReplyTo"));
146​ qCDebug(CMAKE) << "replying..." << inReplyTo;
147​ if (inReplyTo == QLatin1String("handshake"))
mwolffUnsubmitted
Done

QStringLiteral for the "type"

mwolff: QStringLiteral for the "type"
mwolffUnsubmitted
Done

introduce var for type, as it's used again below

mwolff: introduce var for type, as it's used again below
148​ m_server->configure({});
mwolffUnsubmitted
Done

QStringLiteral

mwolff: QStringLiteral
mwolffUnsubmitted
Not Done

add braces to all conditionals here

mwolff: add braces to all conditionals here
149​ else if (inReplyTo == QLatin1String("configure"))
150​ m_server->compute();
mwolffUnsubmitted
Done

QLatin1String

mwolff: QLatin1String
151​ else if (inReplyTo == QLatin1String("compute"))
152​ m_server->codemodel();
153​ else if(inReplyTo == QLatin1String("codemodel")) {
154​ processFileData(response, m_data);
155​ emitResult();
156​ } else
157​ qWarning() << "unhandled reply" << response;
mwolffUnsubmitted
Not Done

braces

mwolff: braces
158​ } else if(responseType == QLatin1String("error")) {
159​ setError(ErrorResponse);
160​ setErrorText(response.value(QLatin1String("errorMessage")).toString());
161​ qWarning() << "error!!" << response;
162​ emitResult();
mwolffUnsubmitted
Done

what's this magic number? is there no enum for this?

mwolff: what's this magic number? is there no enum for this?
163​ } else {
164​ qWarning() << "unhandled message" << response;
165​ }
166​}