Differential D4095 Diff 10266 projectmanagers/cmake/cmakeserverimportjob.cpp

Changeset View

Standalone View

View Options

projectmanagers/cmake/cmakeserverimportjob.cpp

  • This file was added.
1​/* KDevelop CMake Support
2​ *
3​ * Copyright 2014 Kevin Funk <kfunk@kde.org>
mwolffUnsubmitted
Done

really?

mwolff: really?
4​ *
5​ * This program is free software; you can redistribute it and/or
6​ * modify it under the terms of the GNU General Public License
7​ * as published by the Free Software Foundation; either version 2
8​ * of the License, or (at your option) any later version.
9​ *
10​ * This program is distributed in the hope that it will be useful,
11​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
12​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13​ * GNU General Public License for more details.
14​ *
15​ * You should have received a copy of the GNU General Public License
16​ * along with this program; if not, write to the Free Software
17​ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
18​ * 02110-1301, USA.
19​ */
20​
21​#include "cmakeserverimportjob.h"
22​#include "cmakeutils.h"
23​#include "cmakeserver.h"
24​#include <interfaces/iproject.h>
25​#include <QJsonArray>
26​#include <QRegularExpression>
27​#include "debug.h"
28​
29​template <typename T, typename Q, typename W>
kfunkUnsubmitted
Not Done

Style: Off in this whole file, try "Reformat source" with kdev_format script -- you'll be surprised - it works!

kfunk: Style: Off in this whole file, try "Reformat source" with kdev_format script -- you'll be…
30​static T kTransform(const Q& list, W func)
mwolffUnsubmitted
Not Done

you only use it with T == Path::List, so why not hardcode that?

mwolff: you only use it with T == Path::List, so why not hardcode that?
31​{
32​ T ret;
33​ ret.reserve(list.size());
34​ for (auto it = list.constBegin(), itEnd = list.constEnd(); it!=itEnd; ++it)
35​ ret += func(*it);
36​ return ret;
37​}
38​
39​///copied from the makefile resolver
mwolffUnsubmitted
Done

please add it as a getter to the MakefileResolver API, which is used elsewhere in CMake already. That way we don't duplicate this magic

mwolff: please add it as a getter to the MakefileResolver API, which is used elsewhere in CMake already.
40​static QRegularExpression defineRegularExpression()
41​{
42​ static const QRegularExpression pattern(
43​ "-D([^\\s=]+)(?:=(?:\"(.*?)(?<!\\\\)\"|([^\\s]*)))?"
mwolffUnsubmitted
Not Done

QStringLiteral

mwolff: QStringLiteral
44​ );
45​ Q_ASSERT(pattern.isValid());
46​ return pattern;
47​}
48​
49​static QString unescape(const QStringRef& input)
50​{
51​ QString output;
52​ output.reserve(input.length());
53​ bool isEscaped = false;
54​ for (auto it = input.data(), end = it + input.length(); it != end; ++it) {
55​ QChar c = *it;
56​ if (!isEscaped && c == '\\') {
57​ isEscaped = true;
58​ } else {
59​ output.append(c);
60​ isEscaped = false;
61​ }
62​ }
63​ return output;
64​}
65​
66​static QHash<QString, QString> processDefines(const QString &compileFlags, const QJsonArray &defines)
67​{
68​ QHash<QString, QString> ret;
69​ const auto& defineRx = defineRegularExpression();
mwolffUnsubmitted
Done

this could probably be part of a helper function in the MakefileResolver (see above), since that does something like that already elsewhere, I guess?

mwolff: this could probably be part of a helper function in the MakefileResolver (see above), since…
70​ auto it = defineRx.globalMatch(compileFlags);
71​ while (it.hasNext()) {
72​ const auto match = it.next();
mwolffUnsubmitted
Not Done

space after for

mwolff: space after for
73​ QString value;
74​ if (match.lastCapturedIndex() > 1) {
75​ value = unescape(match.capturedRef(match.lastCapturedIndex()));
mwolffUnsubmitted
Not Done

add braces and spaces around operator

mwolff: add braces and spaces around operator
76​ }
77​ ret[match.captured(1)] = value;
78​ }
79​
80​ for(const QJsonValue& defineValue: defines) {
81​ const QString define = defineValue.toString();
82​ const int eqIdx = define.indexOf(QLatin1Char('='));
83​ if (eqIdx<0)
mwolffUnsubmitted
Not Done

spaces around operators

mwolff: spaces around operators
84​ ret[define] = QString();
85​ else
86​ ret[define.left(eqIdx)] = define.mid(eqIdx+1);
87​ }
88​ return ret;
89​}
90​
91​static void processFileData(const QJsonObject &response, CMakeProjectData &data)
92​{
93​ const auto configs = response.value("configurations").toArray();
94​ qCDebug(CMAKE) << "process response" << response;
kfunkUnsubmitted
Done

How polite :)

kfunk: How polite :)
antonanikinUnsubmitted
Not Done

LOL

antonanikin: LOL
95​ for (const auto &config: configs) {
96​ const auto projects = config.toObject().value("projects").toArray();
97​ for (const auto &project: projects) {
98​ const auto targets = project.toObject().value("targets").toArray();
99​ for (const auto &targetObject: targets) {
100​ const auto target = targetObject.toObject();
101​ const KDevelop::Path targetDir(target.value("sourceDirectory").toString());
102​
103​ data.targets[targetDir] += target.value("name").toString();
104​
105​ const auto fileGroups = target.value("fileGroups").toArray();
106​ for (const auto &fileGroupValue: fileGroups) {
107​ const auto fileGroup = fileGroupValue.toObject();
108​ CMakeFile file;
109​ file.includes = kTransform<KDevelop::Path::List>(fileGroup.value("includePath").toArray(), [](const QJsonValue& val) { return KDevelop::Path(val.toObject().value("path").toString()); });
110​ file.defines = processDefines(fileGroup.value("compileFlags").toString(), fileGroup.value("defines").toArray());
111​
112​ const auto sourcesArray = fileGroup.value("sources").toArray();
113​ const KDevelop::Path::List sources = kTransform<KDevelop::Path::List>(sourcesArray, [targetDir](const QJsonValue& val) { return KDevelop::Path(targetDir, val.toString()); });
114​ for (const auto& source: sources) {
115​ data.compilationData.files[source] = file;
116​ }
117​ qCDebug(CMAKE) << "registering..." << sources << file;
118​ }
119​ }
120​ }
121​ }
122​}
123​
124​CMakeServerImportJob::CMakeServerImportJob(KDevelop::IProject* project, QObject* parent)
125​ : KJob(parent)
126​ , m_server(new CMakeServer(this))
127​ , m_project(project)
128​{
129​ connect(m_server, &CMakeServer::disconnected, this, [this]() {
130​ setError(1);
131​ emitResult();
132​ });
133​}
134​
135​void CMakeServerImportJob::start()
136​{
137​ if (m_server->isServerAvailable())
138​ doStart();
139​ else
140​ connect(m_server, &CMakeServer::connected, this, &CMakeServerImportJob::doStart);
141​}
142​
143​void CMakeServerImportJob::doStart()
144​{
145​ connect(m_server, &CMakeServer::response, this, [this](const QJsonObject &response) {
146​ if (response.value("type") == QLatin1String("reply")) {
mwolffUnsubmitted
Done

QStringLiteral for the "type"

mwolff: QStringLiteral for the "type"
mwolffUnsubmitted
Done

introduce var for type, as it's used again below

mwolff: introduce var for type, as it's used again below
147​ const auto inReplyTo = response.value("inReplyTo");
mwolffUnsubmitted
Done

QStringLiteral

mwolff: QStringLiteral
148​ qCDebug(CMAKE) << "replying..." << inReplyTo;
mwolffUnsubmitted
Not Done

add braces to all conditionals here

mwolff: add braces to all conditionals here
149​ if (inReplyTo == "handshake")
mwolffUnsubmitted
Done

QLatin1String

mwolff: QLatin1String
150​ m_server->configure({});
151​ else if (inReplyTo == QLatin1String("configure"))
152​ m_server->compute();
153​ else if (inReplyTo == QLatin1String("compute"))
154​ m_server->codemodel();
155​ else if(inReplyTo == QLatin1String("codemodel")) {
156​ processFileData(response, m_data);
157​ emitResult();
mwolffUnsubmitted
Not Done

braces

mwolff: braces
158​ } else
159​ qWarning() << "unhandled reply" << response;
160​ } else if(response.value("type") == QLatin1String("error")) {
161​ setError(2);
mwolffUnsubmitted
Done

what's this magic number? is there no enum for this?

mwolff: what's this magic number? is there no enum for this?
162​ setErrorText(response.value("errorMessage").toString());
163​ qWarning() << "error!!" << response;
164​ emitResult();
165​ } else {
166​ qWarning() << "unhandled message" << response;
167​ }
168​ });
169​
170​ m_server->handshake(m_project->path(), CMake::currentBuildDir(m_project));
171​}