Differential D4131 Diff 10172 autotests/DeleteItemsTest.h

Changeset View

Standalone View

View Options

autotests/DeleteItemsTest.h

  • This file was added.
1​/* This file is part of the KDE project
2​ Copyright (C) 2012-2016 Jarosław Staniek <staniek@kde.org>
3​
4​ This program is free software; you can redistribute it and/or
5​ modify it under the terms of the GNU Library General Public
6​ License as published by the Free Software Foundation; either
7​ version 2 of the License, or (at your option) any later version.
8​
9​ This program is distributed in the hope that it will be useful,
10​ but WITHOUT ANY WARRANTY; without even the implied warranty of
11​ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
12​ Library General Public License for more details.
13​
14​ You should have received a copy of the GNU Library General Public License
15​ along with this program; see the file COPYING. If not, write to
16​ the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
17​ * Boston, MA 02110-1301, USA.
18​*/
19​
20​#ifndef KDB_DELETEITEMSTEST_H
21​#define KDB_DELETEITEMSTEST_H
22​
23​#include "KDbTestUtils.h"
24​
25​class DeleteItemsTest : public QObject
staniekUnsubmitted
Not Done

I propose to move these methods to KDbTest after testTemporaryTableName(). It's a still a test KDbTest namespace after all.

staniek: I propose to move these methods to `KDbTest` after testTemporaryTableName(). It's a still a…
26​{
27​ Q_OBJECT
28​private Q_SLOTS:
29​ void initTestCase();
30​ void deleteNonExistingrowTest();
staniekUnsubmitted
Not Done

For both names I propose delete -> deleteRecord for 100% clarity we're deleting records, not e.g. tables.

staniek: For both names I propose `delete` -> `deleteRecord` for 100% clarity we're deleting records…
staniekUnsubmitted
Not Done

or deleteNonExistingRecordTest()

and deleteRecordWithTwoConstraintsTest()

staniek: or `deleteNonExistingRecordTest()` and `deleteRecordWithTwoConstraintsTest()`
31​ void DeletewithTwoConstraintsTest();
staniekUnsubmitted
Not Done

Coding style: we're using camelCase for methods.

https://community.kde.org/Policies/Kdelibs_Coding_Style

staniek: Coding style: we're using camelCase for methods. https://community.kde.
32​
33​private:
34​ KDbTestUtils utils;
35​};
36​
37​#endif