Differential D3617 Diff 10034 kcms/touchpad/src/kcm/libinput/components/ToolTip.qml

Changeset View

Standalone View

View Options

kcms/touchpad/src/kcm/libinput/components/ToolTip.qml

  • This file was copied from kcms/touchpad/src/touchpadbackend.cpp.
1/* 1​/*
2 * Copyright (C) 2013 Alexander Mezin <mezin.alexander@gmail.com> 2​ * Copyright 2017 Roman Gilg <subdiff@gmail.com>
3 * 3​ *
4 * This program is free software; you can redistribute it and/or modify 4​ * This program is free software; you can redistribute it and/or modify
5 * it under the terms of the GNU General Public License as published by 5​ * it under the terms of the GNU General Public License as published by
6 * the Free Software Foundation; either version 2 of the License, or 6​ * the Free Software Foundation; either version 2 of the License, or
7 * (at your option) any later version. 7​ * (at your option) any later version.
8 * 8​ *
9 * This program is distributed in the hope that it will be useful, 9​ * This program is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12​ * GNU General Public License for more details.
13 * 13​ *
14 * You should have received a copy of the GNU General Public License 14​ * You should have received a copy of the GNU General Public License
15 * along with this program; if not, write to the Free Software 15​ * along with this program; if not, write to the Free Software
16 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. 16​ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 */ 17​ */
18 18​
19#include "touchpadbackend.h" 19​import QtQuick 2.7
20 20​
21#include <QThreadStorage> 21​import QtQuick.Controls.Private 1.0
22#include <QSharedPointer> ​
23#include <QX11Info> ​
24 22​
25#include "backends/x11/xlibbackend.h" 23​MouseArea {
24​ anchors.fill: parent
sebasUnsubmitted
Done

whitespace looks weird here ... perhaps group the properties, the new properties and the signal handlers in blocks?

sebas: whitespace looks weird here ... perhaps group the properties, the new properties and the signal…
26 25​
27TouchpadBackend::TouchpadBackend(QObject *parent) : QObject(parent) 26​ property string text: ""
28{ 27​
28​ hoverEnabled: true
29​ acceptedButtons: Qt.NoButton
30​
31​ onEntered: timer.start()
32​ onExited: timer.killTooltip()
33​ onPositionChanged: timer.resetTooltip()
34​
35​ Timer {
36​ id: timer
37​ interval: 1000
38​ onTriggered: {
39​ Tooltip.showText(parent, Qt.point(mouseX, mouseY), text)
40​ }
41​
42​ function killTooltip() {
43​ stop()
44​ Tooltip.hideText()
29} 45​ }
sebasUnsubmitted
Done

Could also be hidden by using a onRunningChanged handler, that way the stop() method would 'just work'

sebas: Could also be hidden by using a onRunningChanged handler, that way the stop() method would…
romanggAuthorUnsubmitted
Done

Whenever the running property is changed to false, it automatically should hide the tooltip? But what happens, when it changes to false after a normal enter or position change event and the timer triggered after its interval? Then the tooltip would get hidden again directly.

romangg: Whenever the running property is changed to false, it automatically should hide the tooltip?
sebasUnsubmitted
Done

Right, that could lead to glitches. Good thinking!

sebas: Right, that could lead to glitches. Good thinking!
30 46​
31TouchpadBackend *TouchpadBackend::implementation() 47​ function resetTooltip() {
32{ 48​ restart()
33 //There will be multiple backends later 49​ Tooltip.hideText()
34 static QThreadStorage<QSharedPointer<XlibBackend> > backend; ​
35 if (!backend.hasLocalData()) { ​
36 if (QX11Info::isPlatformX11()) { ​
37 backend.setLocalData(QSharedPointer<XlibBackend>(XlibBackend::initialize())); ​
38 } 50​ }
39 } 51​ }
40 return backend.localData().data(); ​
41} 52​}