Differential D3827 Diff 9402 src/wrtembed/KReportDesignerItemRectBase.h

Changeset View

Standalone View

View Options

src/wrtembed/KReportDesignerItemRectBase.h

Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Line(s)41public:
44 virtual ~KReportDesignerItemRectBase(); 44​ virtual ~KReportDesignerItemRectBase();
45 45​
46 QRectF pointRect() const; 46​ QRectF pointRect() const;
47 47​
48 virtual void enterInlineEditingMode(); 48​ virtual void enterInlineEditingMode();
49 virtual void exitInlineEditingMode(); 49​ virtual void exitInlineEditingMode();
50 50​
51protected: 51​protected:
52 int m_dpiX; 52​ int m_dpiX = 96;
staniekUnsubmitted
Done

BTW, Hmm why KReportDpiSingleton::m_dpiX/Y == 75?

staniek: BTW, Hmm why KReportDpiSingleton::m_dpiX/Y == 75?
piggzAuthorUnsubmitted
Not Done

From what I gather, 96 is most common fall-back dpi, so lets use that

piggz: From what I gather, 96 is most common fall-back dpi, so lets use that
staniekUnsubmitted
Done

both not needed, KReportDesignerItemRectBase initializes them; I propose to mark false positives

staniek: both not needed, KReportDesignerItemRectBase initializes them; I propose to mark false positives
53 int m_dpiY; 53​ int m_dpiY = 96;
54 qreal m_userHeight; 54​ qreal m_userHeight = 0;
staniekUnsubmitted
Done

Hmm are these 4 members used?

staniek: Hmm are these 4 members used?
55 qreal m_userWidth; 55​ qreal m_userWidth = 0;
56 qreal m_pressX; 56​ qreal m_pressX = 0;
57 qreal m_pressY; 57​ qreal m_pressY = 0;
58 58​
59 enum UpdatePropertyFlag { 59​ enum UpdatePropertyFlag {
60 UpdateProperty, 60​ UpdateProperty,
61 DontUpdateProperty 61​ DontUpdateProperty
62 }; 62​ };
63 63​
64 void setSceneRect(const QPointF& topLeft, const QSizeF& size, UpdatePropertyFlag update = UpdateProperty); 64​ void setSceneRect(const QPointF& topLeft, const QSizeF& size, UpdatePropertyFlag update = UpdateProperty);
65 void setSceneRect(const QRectF& rect, UpdatePropertyFlag update = UpdateProperty); 65​ void setSceneRect(const QRectF& rect, UpdatePropertyFlag update = UpdateProperty);
Show All 22 Lines