Differential D3746 Diff 9195 src/renderer/KReportRendererBase.cpp

Changeset View

Standalone View

src/renderer/KReportRendererBase.cpp

Show All 20 Lines
21	#include "KReportScreenRenderer_p.h"	21		#include "KReportScreenRenderer_p.h"
22	#include "KReportPrintRenderer_p.h"	22		#include "KReportPrintRenderer_p.h"
23	#include "KReportKSpreadRenderer.h"	23		#include "KReportKSpreadRenderer.h"
24	#include "KReportHTMLTableRenderer_p.h"	24		#include "KReportHTMLTableRenderer_p.h"
25	#include "KReportHTMLCSSRenderer_p.h"	25		#include "KReportHTMLCSSRenderer_p.h"
26	//! @todo port #include "KReportODTRenderer.h"	26		//! @todo port #include "KReportODTRenderer.h"
27	//! @todo port #include "KOdtFrameReportRenderer.h"	27		//! @todo port #include "KOdtFrameReportRenderer.h"
28		28
		29		class Q_DECL_HIDDEN KReportRendererContext::Private
		30		{
		31		public:
		32		Private();
		33		~Private();
		34		QUrl destinationUrl;
		35		QPainter *painter = nullptr;
			staniekUnsubmitted Done I recommend start using C++11 init instead the `painter(0), printer(0)`; simpler, less error-prone, ie. QPainter painter = nullptr; QPrinter printer = nullptr; staniek: I recommend start using C++11 init instead the `painter(0), printer(0)`; simpler, less error…
		36		QPrinter *printer = nullptr;
		37		};
		38
		39		KReportRendererContext::Private::Private()
		40		{
		41		}
		42
		43		KReportRendererContext::Private::~Private()
		44		{
		45		}
		46
		47
29	KReportRendererContext::KReportRendererContext()	48		KReportRendererContext::KReportRendererContext()
30	: painter(0), printer(0)	49		: d(new Private())
		50		{
		51		}
		52
		53		KReportRendererContext::~KReportRendererContext()
		54		{
		55		delete d;
		56		}
		57
		58		QPainter * KReportRendererContext::painter() const
		59		{
		60		return d->painter;
		61		}
		62
		63		QPrinter * KReportRendererContext::printer() const
		64		{
		65		return d->printer;
		66		}
		67
		68
		69		QPainter * KReportRendererContext::painter()
			staniekUnsubmitted Done missing delete? staniek: missing delete?
31	{	70		{
		71		return d->painter;
32	}	72		}
33		73
		74		QPrinter * KReportRendererContext::printer()
		75		{
		76		return d->printer;
		77		}
		78
		79		void KReportRendererContext::setUrl(const QUrl& url)
		80		{
		81		d->destinationUrl = url;
		82		}
		83
		84		void KReportRendererContext::setPainter(QPainter* painter)
		85		{
		86		d->painter = painter;
		87		}
		88
		89		void KReportRendererContext::setPrinter(QPrinter* printer)
		90		{
		91		d->printer = printer;
		92		}
		93
		94		QUrl KReportRendererContext::url() const
		95		{
		96		return d->destinationUrl;
		97		}
		98
		99
34	KReportRendererBase::KReportRendererBase()	100		KReportRendererBase::KReportRendererBase()
35	{	101		{
36	}	102		}
37		103
38	KReportRendererBase::~KReportRendererBase()	104		KReportRendererBase::~KReportRendererBase()
39	{	105		{
40	}	106		}
41		107
42	KReportRendererFactory::KReportRendererFactory()	108		class KReportRendererFactory::Private
		109		{
		110		public:
		111		bool dummy = true;
			staniekUnsubmitted Done we're adding `bool dummy = true;` to fix build with some compilers staniek: we're adding `bool dummy = true;` to fix build with some compilers
		112		};
		113
		114		KReportRendererFactory::KReportRendererFactory() : d(new Private())
			staniekUnsubmitted Done missing delete staniek: missing delete
		115		{
		116		}
		117
		118		KReportRendererFactory::~KReportRendererFactory()
43	{	119		{
		120		delete d;
44	}	121		}
45		122
46	KReportRendererBase* KReportRendererFactory::createInstance(const QString& key)	123		KReportRendererBase* KReportRendererFactory::createInstance(const QString& key)
47	{	124		{
48	const QString lowerKey = key.toLower();	125		const QString lowerKey = key.toLower();
49	if (lowerKey == QLatin1String("screen")) {	126		if (lowerKey == QLatin1String("screen")) {
50	return new KReportPrivate::ScreenRenderer();	127		return new KReportPrivate::ScreenRenderer();
51	}	128		}
Show All 26 Lines