Differential D3580 Diff 8725 plugins/testview/testview.cpp

Changeset View

Standalone View

View Options

plugins/testview/testview.cpp

Context not available.
239 239​
240QStandardItem* TestView::itemForProject(IProject* project) 240​QStandardItem* TestView::itemForProject(IProject* project)
241{ 241​{
242 foreach (QStandardItem* item, m_model->findItems(project->name())) 242​ QList<QStandardItem*> stditemlist = m_model->findItems(project->name());
243 { 243​ if (stditemlist.size() > 0) {
ematirovUnsubmitted
Not Done

Let's use just !stditemlist.IsEmpty() and stditemlist.first().
And probably "itemsForProject" or something like so will be more meaningful name for that. ;)

ematirov: Let's use just !stditemlist.IsEmpty() and stditemlist.first(). And probably "itemsForProject"…
ematirovUnsubmitted
Not Done

It should be !itemsForProject.isEmpty(), not just itemsForProject.isEmpty(). Now it works like:
Check if list is empty (does not contain items) and if it's empty return first item; which is incorrect.

ematirov: It should be !itemsForProject.isEmpty(), not just itemsForProject.isEmpty(). Now it works like…
244 return item; 244​ return stditemlist.at(0);
245 } 245​ }
246 ​
247 return addProject(project); 246​ return addProject(project);
248} 247​}
249 248​
Context not available.