Differential D3550 Diff 8716 plugins/grepview/grepjob.h

Changeset View

Standalone View

plugins/grepview/grepjob.h

Context not available.
36	class GrepViewPlugin;	36		class GrepViewPlugin;
37	class FindReplaceTest; //FIXME: this is useful only for tests	37		class FindReplaceTest; //FIXME: this is useful only for tests
38		38
		39		struct GrepJobSettings {
			kfunkUnsubmitted Done Minor style issue: Newline before `{` kfunk: Minor style issue: Newline before `{`
		40		bool projectFilesOnly = false;
		41		bool caseSensitive = true;
		42		bool regexp = true;
		43
		44		int depth = -1;
		45
		46		QString pattern;
		47		QString searchTemplate;
			ematirovUnsubmitted Done Maybe some more readable name? Something like "template" or maybe "searchTemplate". ematirov: Maybe some more readable name? Something like "template" or maybe "searchTemplate".
		48		QString replacementTemplate;
		49		QString files;
		50		QString exclude;
		51		};
		52
39	class GrepJob : public KJob, public KDevelop::IStatus	53		class GrepJob : public KJob, public KDevelop::IStatus
40	{	54		{
41	Q_OBJECT	55		Q_OBJECT
Context not available.
49	explicit GrepJob( QObject *parent = nullptr );	63		explicit GrepJob( QObject *parent = nullptr );
50		64
51	public:	65		public:
		66		void setSettings(const GrepJobSettings& settings);
		67		GrepJobSettings settings() const;
52		68
			ematirovUnsubmitted Done What's point of using comments here? It's not necessary since old version still be available on git in case it'll be needed. ematirov: What's point of using comments here? It's not necessary since old version still be available on…
53	void setOutputModel(GrepOutputModel * model);	69		void setOutputModel(GrepOutputModel * model);
54	void setPatternString(const QString& patternString);
55	void setTemplateString(const QString &templateString);
56	void setReplacementTemplateString(const QString &replTmplString);
57	void setFilesString(const QString &filesString);
58	void setExcludeString(const QString &excludeString);
59	void setDirectoryChoice(const QList<QUrl> &choice);	70		void setDirectoryChoice(const QList<QUrl> &choice);
60	void setDepth(int depth);
61	void setRegexpFlag(bool regexpFlag);
62	void setCaseSensitive(bool caseSensitive);
63	void setProjectFilesFlag(bool projectFilesFlag);
64		71
65	void start() override;	72		void start() override;
66		73
Context not available.
85	private:	92		private:
86	Q_INVOKABLE void slotWork();	93		Q_INVOKABLE void slotWork();
87		94
88	QString m_patternString;	95		QList<QUrl> m_directoryChoice;
		96		QString m_errorMessage;
		97
89	QRegExp m_regExp;	98		QRegExp m_regExp;
90	QString m_regExpSimple;	99		QString m_regExpSimple;
91	GrepOutputModel *m_outputModel;	100		GrepOutputModel *m_outputModel;
Context not available.
101	int m_fileIndex;	110		int m_fileIndex;
102	QPointer<GrepFindFilesThread> m_findThread;	111		QPointer<GrepFindFilesThread> m_findThread;
103		112
104	QString m_errorMessage;	113		GrepJobSettings m_settings;
105	QString m_templateString;	114
106	QString m_replacementTemplateString;
107	QString m_filesString;
108	QString m_excludeString;
109	QList<QUrl> m_directoryChoice;
110
111	bool m_useProjectFilesFlag;
112	bool m_regexpFlag;
113	bool m_caseSensitiveFlag;
114	int m_depthValue;
115
116	bool m_findSomething;	115		bool m_findSomething;
117	};	116		};
118		117
Context not available.
			ematirovUnsubmitted Done Same there. Indentation issue. ematirov: Same there. Indentation issue.
			ematirovUnsubmitted Done Is m_templateString used somewhere now? If no, please remove it. ematirov: Is m_templateString used somewhere now? If no, please remove it.