Changeset View
Standalone View
CMakeLists.txt
Show All 23 Lines | |||||
24 | include(KDEFrameworkCompilerSettings) | 24 | include(KDEFrameworkCompilerSettings) | ||
25 | include(KDECMakeSettings) | 25 | include(KDECMakeSettings) | ||
26 | 26 | | |||
27 | include(FeatureSummary) | 27 | include(FeatureSummary) | ||
28 | include(GenerateExportHeader) | 28 | include(GenerateExportHeader) | ||
29 | include(MacroLogFeature) | 29 | include(MacroLogFeature) | ||
30 | include(KPropertyMacros) | 30 | include(KPropertyMacros) | ||
31 | include(KPropertyAddIconsRccFile) | 31 | include(KPropertyAddIconsRccFile) | ||
32 | include(KPropertyAddQCH) | ||||
32 | 33 | | |||
34 | simple_option(BUILD_QCH "Build API documentation in QCH format" OFF) | ||||
staniek: ON by default? I am wondering about overhead. | |||||
staniek: BTW, what's the default for KF5 for example? | |||||
The overhead currently is pretty small from what I experience. On my machine (SSD) the QCH generation feels to take a similar long time as an .o file generation. The current patches for KF5 also use ON as default (cmp. https://phabricator.kde.org/D3458, https://phabricator.kde.org/D3439, https://phabricator.kde.org/D3438), just nobody has yet started to review and give feedback, so currently lack of further opinions. kossebau: The overhead currently is pretty small from what I experience. On my machine (SSD) the QCH… | |||||
OK, I am thinking about OFF as the default. We never know what's the reason of building: preparing package is only a tiny fraction of cases, actually one of the last. We never know if people prefer HTML of PDF docs. During development generating anything for every build is costly. I would say we can equally well document a note that developers can set to OFF but in real world there are more developers than packagers, so I believe it's somewhat better to say packagers to set it ON in README.PACKAGERS. staniek: OK, I am thinking about OFF as the default. We never know what's the reason of building… | |||||
33 | simple_option(KPROPERTY_WIDGETS "Build the QtWidget components of KProperty" ON) | 35 | simple_option(KPROPERTY_WIDGETS "Build the QtWidget components of KProperty" ON) | ||
34 | simple_option(KPROPERTY_KF "Build components depending on KDE Frameworks" ON) | 36 | simple_option(KPROPERTY_KF "Build components depending on KDE Frameworks" ON) | ||
35 | 37 | | |||
36 | # Dependencies | 38 | # Dependencies | ||
37 | set(REQUIRED_QT_VERSION "5.2.0") | 39 | set(REQUIRED_QT_VERSION "5.2.0") | ||
38 | set(REQUIRED_KF5_VERSION 5.7.0) | 40 | set(REQUIRED_KF5_VERSION 5.7.0) | ||
39 | 41 | | |||
40 | find_package(Qt5 ${REQUIRED_QT_VERSION} NO_MODULE REQUIRED Core) | 42 | find_package(Qt5 ${REQUIRED_QT_VERSION} NO_MODULE REQUIRED Core) | ||
Show All 25 Lines |
ON by default? I am wondering about overhead.