Differential D3260 Diff 8135 autotests/knewstuffauthortest.cpp

Changeset View

Standalone View

View Options

autotests/knewstuffauthortest.cpp

Context not available.
39 39​
40void testAuthor::testProperties() 40​void testAuthor::testProperties()
41{ 41​{
42 KNS3::Author author; 42​ KNSCore::Author author;
apolUnsubmitted
Not Done

Is this change really necessary? The API should be backwards compatible.

apol: Is this change really necessary? The API should be backwards compatible.
leinirAuthorUnsubmitted
Not Done

Author was not previously exported, so there isn't a great deal of difference here... Not sure why this would be an issue? Anything in KNSCore was previously not exported, so the API was never publicly exposed...

leinir: Author was not previously exported, so there isn't a great deal of difference here... Not sure…
43 author.setName(name); 43​ author.setName(name);
44 author.setEmail(email); 44​ author.setEmail(email);
45 author.setJabber(jabber); 45​ author.setJabber(jabber);
Context not available.
52 52​
53void testAuthor::testCopy() 53​void testAuthor::testCopy()
54{ 54​{
55 KNS3::Author author; 55​ KNSCore::Author author;
56 author.setName(name); 56​ author.setName(name);
57 author.setEmail(email); 57​ author.setEmail(email);
58 author.setJabber(jabber); 58​ author.setJabber(jabber);
59 author.setHomepage(homepage); 59​ author.setHomepage(homepage);
60 KNS3::Author author2(author); 60​ KNSCore::Author author2(author);
61 QCOMPARE(author.name(), author2.name()); 61​ QCOMPARE(author.name(), author2.name());
62 QCOMPARE(author.email(), author2.email()); 62​ QCOMPARE(author.email(), author2.email());
63 QCOMPARE(author.jabber(), author2.jabber()); 63​ QCOMPARE(author.jabber(), author2.jabber());
Context not available.
66 66​
67void testAuthor::testAssignment() 67​void testAuthor::testAssignment()
68{ 68​{
69 KNS3::Author author; 69​ KNSCore::Author author;
70 KNS3::Author author2; 70​ KNSCore::Author author2;
71 author.setName(name); 71​ author.setName(name);
72 author.setEmail(email); 72​ author.setEmail(email);
73 author.setJabber(jabber); 73​ author.setJabber(jabber);
Context not available.