Differential D3322 Diff 8103 src/common/KReportDocument.h

Changeset View

Standalone View

src/common/KReportDocument.h

Show All 10 Lines
11	* but WITHOUT ANY WARRANTY; without even the implied warranty of	11		* but WITHOUT ANY WARRANTY; without even the implied warranty of
12	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU	12		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13	* Lesser General Public License for more details.	13		* Lesser General Public License for more details.
14	*	14		*
15	* You should have received a copy of the GNU Lesser General Public	15		* You should have received a copy of the GNU Lesser General Public
16	* License along with this library. If not, see <http://www.gnu.org/licenses/>.	16		* License along with this library. If not, see <http://www.gnu.org/licenses/>.
17	*/	17		*/
18		18
19	#ifndef KREPORTSCHEMADATA_H	19		#ifndef KREPORTSCHEMADATA_H
			staniekUnsubmitted Done While we're at it: `-> KREPORTDOCUMENT_H` staniek: While we're at it: `-> KREPORTDOCUMENT_H`
20	#define KREPORTSCHEMADATA_H	20		#define KREPORTSCHEMADATA_H
21		21
22	#include "config-kreport.h"	22		#include "config-kreport.h"
23	#include "kreport_export.h"	23		#include "kreport_export.h"
24	#include "KReportSectionData.h"	24		#include "KReportSectionData.h"
25	#include "KReportPageOptions.h"	25
		26		#include <QPageLayout>
26		27
27	class KReportDetailSectionData;	28		class KReportDetailSectionData;
28		29
29	#ifdef KREPORT_SCRIPTING	30		#ifdef KREPORT_SCRIPTING
30	namespace Scripting	31		namespace Scripting
31	{	32		{
32	class Report;	33		class Report;
33	}	34		}
▲ Show 20 Lines • Show All 49 Lines • ▼ Show 20 Line(s)		80	#endif
83	KReportDetailSectionData* detail() const {	84		KReportDetailSectionData* detail() const {
84	return m_detailSection;	85		return m_detailSection;
85	}	86		}
86		87
87	void setName(const QString&n);	88		void setName(const QString&n);
88	QString name() const;	89		QString name() const;
89		90
90	QString title() const;	91		QString title() const;
91	KReportPageOptions pageOptions() const;	92
		93		QPageLayout pageLayout() const;
		94
		95		QString pageSize();
		96		void setPageSize(const QString &size);
		97
		98		QString labelType();
			staniekUnsubmitted Done +const staniek: +const
			staniekUnsubmitted Done If it's unused shouldn't we add #if 0 around this getter and setter? We don't know exact API we'll need for label types... staniek: If it's unused shouldn't we add #if 0 around this getter and setter? We don't know exact API…
			piggzAuthorUnsubmitted Done i agree, however, the parser has always supported loading the label info from the XML, we just dont expose it, so I think we need somewhere to load to, even though we dont expose it yet. The loading code is ported from the original OpenRPT, and the label definitions are also from there. What do u think? piggz: i agree, however, the parser has always supported loading the label info from the XML, we just…
			staniekUnsubmitted Done I see KReportPreRendererPrivate::generateDocument() uses labelType(). Because KReportPreRendererPrivate is a friend of KReportDocument, would it be possible to make labelType/setLabelType private for now? With a //! @todo add support for labels? staniek: I see KReportPreRendererPrivate::generateDocument() uses labelType(). Because…
		99		void setLabelType(const QString &label);
92		100
93	protected:	101		protected:
94		102
95		103
96	KReportSectionData * m_pageHeaderFirst;	104		KReportSectionData * m_pageHeaderFirst;
97	KReportSectionData * m_pageHeaderOdd;	105		KReportSectionData * m_pageHeaderOdd;
98	KReportSectionData * m_pageHeaderEven;	106		KReportSectionData * m_pageHeaderEven;
99	KReportSectionData * m_pageHeaderLast;	107		KReportSectionData * m_pageHeaderLast;
Show All 27 Lines