Differential D3188 Diff 7719 wallpapers/image/testfindpreferredimage.cpp

Changeset View

Standalone View

View Options

wallpapers/image/testfindpreferredimage.cpp

  • This file was added.
1​/***************************************************************************
2​ * Copyright 2016 Antonio Larrosa <larrosa@kde.org> *
3​ * *
4​ * This program is free software; you can redistribute it and/or modify *
5​ * it under the terms of the GNU General Public License as published by *
6​ * the Free Software Foundation; either version 2 of the License, or *
7​ * (at your option) any later version. *
8​ * *
9​ * This program is distributed in the hope that it will be useful, *
10​ * but WITHOUT ANY WARRANTY; without even the implied warranty of *
11​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
12​ * GNU General Public License for more details. *
13​ * *
14​ * You should have received a copy of the GNU General Public License *
15​ * along with this program; if not, write to the *
16​ * Free Software Foundation, Inc., *
17​ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA . *
18​ ***************************************************************************/
19​#include "image.h"
20​#include <QApplication>
21​#include <QDebug>
22​#include <iostream>
23​
24​extern QSize resSize(const QString &str);
25​
26​QString formatResolution(const QString &str)
27​{
28​ QSize size = resSize(str);
29​ float aspectRatio = (size.height() > 0 ) ? size.width() / (float)size.height() : 0;
30​ return QString("%1 (%2)").arg(str, 9).arg(aspectRatio, 7);
31​}
32​
33​int main(int argc, char **argv)
34​{
35​ QApplication app(argc, argv);
36​
37​ Image image;
38​
39​ // The list of available wallpaper image sizes
40​ QStringList images;
41​ images << QStringLiteral("1280x1024")
42​ << QStringLiteral("1350x1080")
43​ << QStringLiteral("1440x1080")
44​ << QStringLiteral("1600x1200")
45​ << QStringLiteral("1920x1080")
46​ << QStringLiteral("1920x1200")
47​ << QStringLiteral("3840x2400");
48​ std::cout << "Available images:" << std::endl;
49​ foreach( auto image, images) {
50​ std::cout << qPrintable(formatResolution(image)) << std::endl;
51​ }
52​
53​
54​ // The list of possible screen resolutions to test and the appropiate images that should be chosen
55​ QList<QPair<QString, QString> > resolutions;
56​ resolutions << qMakePair(QStringLiteral("1280x1024"), QStringLiteral("1280x1024"))
57​ << qMakePair(QStringLiteral("1350x1080"), QStringLiteral("1350x1080"))
58​ << qMakePair(QStringLiteral("1440x1080"), QStringLiteral("1440x1080"))
59​ << qMakePair(QStringLiteral("1600x1200"), QStringLiteral("1600x1200"))
60​ << qMakePair(QStringLiteral("1920x1080"), QStringLiteral("1920x1080"))
61​ << qMakePair(QStringLiteral("1920x1200"), QStringLiteral("1920x1200"))
62​ << qMakePair(QStringLiteral("3840x2400"), QStringLiteral("3840x2400"))
63​ << qMakePair(QStringLiteral("1680x1050"), QStringLiteral("1920x1200"))
64​ << qMakePair(QStringLiteral("1400x1050"), QStringLiteral("1440x1080"))
65​ << qMakePair(QStringLiteral("1440x900"), QStringLiteral("1920x1200"))
66​ << qMakePair(QStringLiteral("1280x960"), QStringLiteral("1440x1080"))
67​ << qMakePair(QStringLiteral("1280x854"), QStringLiteral("1920x1200"))
68​ << qMakePair(QStringLiteral("1280x800"), QStringLiteral("1920x1200"))
69​ << qMakePair(QStringLiteral("1280x720"), QStringLiteral("1920x1080"))
70​ << qMakePair(QStringLiteral("1152x768"), QStringLiteral("1920x1200"))
71​ << qMakePair(QStringLiteral("1024x768"), QStringLiteral("1440x1080"))
72​ << qMakePair(QStringLiteral("800x600"), QStringLiteral("1440x1080"))
73​ << qMakePair(QStringLiteral("848x480"), QStringLiteral("1920x1080"))
74​ << qMakePair(QStringLiteral("720x480"), QStringLiteral("1920x1200"))
75​ << qMakePair(QStringLiteral("640x480"), QStringLiteral("1440x1080"))
76​ << qMakePair(QStringLiteral("1366x768"), QStringLiteral("1920x1080"))
77​ << qMakePair(QStringLiteral("1600x814"), QStringLiteral("1920x1080"));
78​
79​ std::cout << "Tests:" << std::endl;
80​ int total = 0;
81​ int failed = 0;
82​ foreach ( auto pair, resolutions ) {
83​ const QString resolution = pair.first;
84​ const QString expected = pair.second;
85​
86​ image.setTargetSize( resSize( resolution ) );
87​ QString preferred = image.findPreferedImage(images);
88​
89​ total++;
90​ if (preferred != expected) failed++;
martUnsubmitted
Done

good that a test has been added!
but instead of doing all of this manually, couldn't it use qt autotest stuff, qcompare, qtest etc?

mart: good that a test has been added! but instead of doing all of this manually, couldn't it use qt…
antlarrAuthorUnsubmitted
Done

I never used QTest before and I thought about that but preferred to do it as fast as possible. I guess I'll have to write it anyway :)

antlarr: I never used QTest before and I thought about that but preferred to do it as fast as possible.
91​ std::cout << "For a screen size of " << qPrintable(formatResolution(resolution))
antlarrAuthorUnsubmitted
Done

I'll fix indentation around all the file in the next commit. But I'll wait to see if there's any other change to make

antlarr: I'll fix indentation around all the file in the next commit. But I'll wait to see if there's…
92​ << " the " << qPrintable(formatResolution(preferred)) << " wallpaper was preferred: "
93​ << (preferred == expected ? "OK" : "FAILED!") << std::endl;
94​ }
95​
96​ std::cout << "Total number of tests: " << total << std::endl;
97​ if (failed == 0) std::cout << "All tests passed successfully" << std::endl;
98​ else std::cout << failed << " tests FAILED" << std::endl;
99​
100​ return failed != 0;
101​}
102​