Differential D3164 Diff 7671 plugins/problemreporter/problemreporterplugin.cpp

Changeset View

Standalone View

plugins/problemreporter/problemreporterplugin.cpp

Context not available.
99	connect(ICore::self()->languageController()->staticAssistantsManager(), &StaticAssistantsManager::problemsChanged,	99		connect(ICore::self()->languageController()->staticAssistantsManager(), &StaticAssistantsManager::problemsChanged,
100	this, &ProblemReporterPlugin::updateHighlight);	100		this, &ProblemReporterPlugin::updateHighlight);
101	connect(pms, &ProblemModelSet::showRequested, this, &ProblemReporterPlugin::showModel);	101		connect(pms, &ProblemModelSet::showRequested, this, &ProblemReporterPlugin::showModel);
		102		connect(pms, &ProblemModelSet::problemsChanged, this, &ProblemReporterPlugin::updateOpenedDocumentsHighlight);
102	}	103		}
103		104
104	ProblemReporterPlugin::~ProblemReporterPlugin()	105		ProblemReporterPlugin::~ProblemReporterPlugin()
Context not available.
145	void ProblemReporterPlugin::updateHighlight(const KDevelop::IndexedString& url)	146		void ProblemReporterPlugin::updateHighlight(const KDevelop::IndexedString& url)
146	{	147		{
147	ProblemHighlighter* ph = m_highlighters.value(url);	148		ProblemHighlighter* ph = m_highlighters.value(url);
148	if (ph) {	149		if (!ph)
149	auto allProblems = m_model->problems(url, false);	150		return;
150	ph->setProblems(allProblems);	151
151	}	152		KDevelop::ProblemModelSet* pms(core()->languageController()->problemModelSet());
		153		QVector<IProblem::Ptr> documentProblems;
		154
		155		foreach (const ModelData& modelData, pms->models()) {
		156		documentProblems += modelData.model->problems(url);
		157		}
		158
		159		ph->setProblems(documentProblems);
152	}	160		}
153		161
154	void ProblemReporterPlugin::showModel(const QString& name)	162		void ProblemReporterPlugin::showModel(const QString& name)
Context not available.
208	return extension;	216		return extension;
209	}	217		}
210		218
		219		void ProblemReporterPlugin::updateOpenedDocumentsHighlight()
			kfunkUnsubmitted Not Done Hm, why do update the problems for all open documents now? This could get slow with lots of documents open at a time, no? kfunk: Hm, why do update the problems for all open documents now? This could get slow with lots of…
			antonanikinAuthorUnsubmitted Not Done This is necessary due re-highlighting is not performed automatically for opened documents. If we switch to other opened document it will have "old highlights" which is wrong. Currently re-highlighting runs only for new opened documents. My previous version do it (with using other signals connected) for such case but it's wrong to run re-highlighting every time for non-changed problems. We can add some mechanism to save re-highlighting "queries" to some structure (like vector) and run needed on document switch. I can do it in next revision if necessary. antonanikin: This is necessary due re-highlighting is not performed automatically for opened documents. If…
		220		{
		221		foreach(auto document, core()->documentController()->openDocuments()) {
		222		updateHighlight(IndexedString(document->url().toLocalFile()));
		223		}
		224		}
		225
211	#include "problemreporterplugin.moc"	226		#include "problemreporterplugin.moc"
212		227
213	// kate: space-indent on; indent-width 2; tab-width 4; replace-tabs on; auto-insert-doxygen on	228		// kate: space-indent on; indent-width 2; tab-width 4; replace-tabs on; auto-insert-doxygen on
Context not available.