Changeset View
Changeset View
Standalone View
Standalone View
sftp/CMakeLists.txt
Show All 16 Lines | 14 | ecm_qt_declare_logging_category(kio_sftp_SRCS | |||
---|---|---|---|---|---|
17 | CATEGORY_NAME log_kio_sftp.trace) | 17 | CATEGORY_NAME log_kio_sftp.trace) | ||
18 | 18 | | |||
19 | add_library(kio_sftp MODULE ${kio_sftp_SRCS}) | 19 | add_library(kio_sftp MODULE ${kio_sftp_SRCS}) | ||
20 | target_link_libraries(kio_sftp | 20 | target_link_libraries(kio_sftp | ||
21 | KF5::KIOCore | 21 | KF5::KIOCore | ||
22 | KF5::WidgetsAddons # KMessageBox | 22 | KF5::WidgetsAddons # KMessageBox | ||
23 | KF5::I18n | 23 | KF5::I18n | ||
24 | Qt5::Network | 24 | Qt5::Network | ||
25 | ssh) | 25 | ssh) | ||
sitter: Hm, I am a bit hazy on the details but I think this changes makes no sense. libssh (upstream)… | |||||
I just built libssh 0.9.4, and kio-extras builds fine without this line change. Maybe we should try getting latest libssh onboard. Can I help in that somehow @vonreth ? brute4s99: I just built libssh 0.9.4, and kio-extras builds fine without this line change. Maybe we should… | |||||
vonreth: yes pls update libssh | |||||
Hi! Sorry, I got around to this patch quite late. I added a new patch for 0.9.4 release as parent revision to this revision, please take a look. ^_^ brute4s99: Hi! Sorry, I got around to this patch quite late. I added a new patch for 0.9.4 release as… | |||||
26 | set_target_properties(kio_sftp PROPERTIES OUTPUT_NAME "sftp") | 26 | set_target_properties(kio_sftp PROPERTIES OUTPUT_NAME "sftp") | ||
27 | 27 | | |||
28 | install(TARGETS kio_sftp DESTINATION ${KDE_INSTALL_PLUGINDIR}/kf5/kio) | 28 | install(TARGETS kio_sftp DESTINATION ${KDE_INSTALL_PLUGINDIR}/kf5/kio) | ||
29 | 29 | | |||
30 | install( FILES sftp.protocol DESTINATION ${KDE_INSTALL_KSERVICES5DIR} ) | 30 | install( FILES sftp.protocol DESTINATION ${KDE_INSTALL_KSERVICES5DIR} ) |
Hm, I am a bit hazy on the details but I think this changes makes no sense. libssh (upstream) introduced an imported target ssh. For backwards compatibility we also inject this target when building with older libssh's than the latest (to be honest though, with libssh you basically always want the latest or you'll have an incredibly subpar experience).