Differential D29807 Diff 83029 runners/bookmarks/browsers/chromeprofile.cpp

Changeset View

Standalone View

View Options

runners/bookmarks/browsers/chromeprofile.cpp

  • This file was added.
1​#include "chromeprofile.h"
2​
3​#include <QJsonDocument>
4​#include <QJsonObject>
5​#include <QDebug>
6​
mevenUnsubmitted
Not Done

Is this used ?

meven: Is this used ?
7​ProfileBookmarks::ProfileBookmarks(const QString &path, const QString &name)
8​ : m_path(path), m_name(name), m_favicon(nullptr) {
9​ // Remove "Bookmarks" from end of path
mevenUnsubmitted
Done

{ on new line

meven: `{` on new line
10​ m_faviconSource = path.chopped(9) + QStringLiteral("Favicons");
11​ m_faviconCache = QStringLiteral("%1/KRunner-Chrome-Favicons-%2.sqlite")
12​ .arg(QStandardPaths::writableLocation(QStandardPaths::CacheLocation), name);
13​}
14​
15​QList<ProfileBookmarks *> ProfileBookmarks::findAllProfiles(const QString &applicationName)
16​{
17​ const QString configDirectory = QStandardPaths::writableLocation(QStandardPaths::ConfigLocation) + '/' + applicationName;
18​ const QString localStateFileName = QStringLiteral("%1/Local State").arg(configDirectory);
19​ QList<ProfileBookmarks *> profiles;
20​ QFile localStateFile(localStateFileName);
21​
22​ if (!localStateFile.open(QIODevice::ReadOnly | QIODevice::Text)) {
23​ return profiles;
24​ }
25​ const QJsonDocument jdoc = QJsonDocument::fromJson(localStateFile.readAll());
26​ if(jdoc.isNull()) {
27​ qDebug() << "error opening " << QFileInfo(localStateFile).absoluteFilePath();
28​ return profiles;
mevenUnsubmitted
Done

Remove

meven: Remove
29​ }
30​
31​ const QVariantMap localState = jdoc.object().toVariantMap();
32​ const QStringList profilesConfigKeys = localState.value(QStringLiteral("profile")).toMap()
33​ .value(QStringLiteral("info_cache")).toMap().keys();
34​ for (const QString &profile : profilesConfigKeys) {
mevenUnsubmitted
Done

Perhaps use an iterator instead of copying the keys.

meven: Perhaps use an iterator instead of copying the keys.
35​ const QString profilePath = configDirectory + '/' + profile;
36​ const QString profileBookmarksPath = profilePath + '/' + QStringLiteral("Bookmarks");
37​ profiles << new ProfileBookmarks(profileBookmarksPath, profile);
38​ }
39​ return profiles;
40​}