Differential D28922 Diff 82289 faces/SensorFaceController.h

Changeset View

Standalone View

View Options

faces/SensorFaceController.h

  • This file was added.
1​/*
2​ Copyright (C) 2020 Marco Martin <mart@kde.org>
3​
4​ This library is free software; you can redistribute it and/or
5​ modify it under the terms of the GNU Library General Public
6​ License as published by the Free Software Foundation; either
7​ version 2 of the License, or (at your option) any later version.
8​
9​ This library is distributed in the hope that it will be useful,
10​ but WITHOUT ANY WARRANTY; without even the implied warranty of
11​ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
12​ Library General Public License for more details.
13​
14​ You should have received a copy of the GNU Library General Public License
15​ along with this library; see the file COPYING.LIB. If not, write to
16​ the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
17​ Boston, MA 02110-1301, USA.
18​*/
19​
20​#pragma once
21​
22​#include <QObject>
23​#include <QPointer>
24​#include <QQuickItem>
25​#include <QAbstractItemModel>
26​
27​#include <KConfigGroup>
28​
29​#include "sensorfaces_export.h"
30​
31​namespace KDeclarative {
32​ class ConfigPropertyMap;
33​}
34​
35​class QQmlEngine;
36​class KDesktopFile;
37​class KConfigLoader;
38​
39​namespace KSysGuard {
40​
41​class SensorFace;
42​
43​class SENSORFACES_EXPORT SensorFaceController : public QObject
ahiemstraUnsubmitted
Done

Can you place this class (and related classes) in the KSysGuard namespace? Then it would match the rest of the libraries.

ahiemstra: Can you place this class (and related classes) in the KSysGuard namespace? Then it would match…
44​{
45​ Q_OBJECT
46​ Q_PROPERTY(QString title READ title WRITE setTitle NOTIFY titleChanged)
47​ Q_PROPERTY(QString faceId READ faceId WRITE setFaceId NOTIFY faceIdChanged)
48​ Q_PROPERTY(QJsonArray totalSensors READ totalSensors WRITE setTotalSensors NOTIFY totalSensorsChanged)
ahiemstraUnsubmitted
Done

I think it would be a good idea to make this a list of ids as well. My current use case would be the "used/total" version of the pie chart that is used in KSysGuardQML, which would need two "total" sensors.

ahiemstra: I think it would be a good idea to make this a list of ids as well. My current use case would…
martAuthorUnsubmitted
Done

how would that work in current faces that have this binded to that single big number inside graphs?

mart: how would that work in current faces that have this binded to that single big number inside…
ahiemstraUnsubmitted
Done

You'd use the first one from the list? If we want to limit it I think we need to limit it in the UI, not in the backend, since that leads to a complete inability to do anything different.

ahiemstra: You'd use the first one from the list? If we want to limit it I think we need to limit it in…
49​ Q_PROPERTY(QJsonArray highPrioritySensorIds READ highPrioritySensorIds WRITE setHighPrioritySensorIds NOTIFY highPrioritySensorIdsChanged)
50​ Q_PROPERTY(QVariantMap sensorColors READ sensorColors WRITE setSensorColors NOTIFY sensorColorsChanged)
51​ Q_PROPERTY(QJsonArray lowPrioritySensorIds READ lowPrioritySensorIds WRITE setLowPrioritySensorIds NOTIFY lowPrioritySensorIdsChanged)
ahiemstraUnsubmitted
Done

Hmm, maybe these names are a little too use-case specific? I wonder if it would make sense to name them "highPrioritySensorsIds", "sensorIds", "lowPrioritySensorIds" or so.

ahiemstra: Hmm, maybe these names are a little too use-case specific? I wonder if it would make sense to…
52​
53​ Q_PROPERTY(QString name READ name NOTIFY faceIdChanged)
54​ Q_PROPERTY(QString icon READ icon NOTIFY faceIdChanged)
55​ Q_PROPERTY(bool supportsSensorsColors READ supportsSensorsColors NOTIFY faceIdChanged)
56​ Q_PROPERTY(bool supportsTotalSensors READ supportsTotalSensors NOTIFY faceIdChanged)
57​ Q_PROPERTY(bool supportsLowPrioritySensors READ supportsLowPrioritySensors NOTIFY faceIdChanged)
58​ Q_PROPERTY(KDeclarative::ConfigPropertyMap *faceConfiguration READ faceConfiguration NOTIFY faceIdChanged)
59​
60​ Q_PROPERTY(QQuickItem *fullRepresentation READ fullRepresentation NOTIFY faceIdChanged)
61​ Q_PROPERTY(QQuickItem *compactRepresentation READ compactRepresentation NOTIFY faceIdChanged)
62​ Q_PROPERTY(QQuickItem *faceConfigUi READ faceConfigUi NOTIFY faceIdChanged)
63​ Q_PROPERTY(QQuickItem *appearanceConfigUi READ appearanceConfigUi NOTIFY faceIdChanged)
64​ Q_PROPERTY(QQuickItem *sensorsConfigUi READ sensorsConfigUi NOTIFY faceIdChanged)
65​
66​ Q_PROPERTY(QAbstractItemModel *availableFacesModel READ availableFacesModel CONSTANT)
67​ Q_PROPERTY(QAbstractItemModel *availablePresetsModel READ availablePresetsModel CONSTANT)
68​
69​public:
70​ SensorFaceController(KConfigGroup &config, QQmlEngine *engine);
71​ ~SensorFaceController();
72​
73​ void setFaceId(const QString &face);
74​ QString faceId() const;
75​
76​ QQuickItem *fullRepresentation();
77​ QQuickItem *compactRepresentation();
ahiemstraUnsubmitted
Done

This seems superfluous?

ahiemstra: This seems superfluous?
78​ QQuickItem *faceConfigUi();
79​ QQuickItem *appearanceConfigUi();
80​ QQuickItem *sensorsConfigUi();
81​
82​ KDeclarative::ConfigPropertyMap *faceConfiguration() const;
83​
84​ QString title() const;
85​ void setTitle(const QString &title);
86​
87​ QJsonArray totalSensors() const;
88​ void setTotalSensors(const QJsonArray &sensor);
89​
90​ QJsonArray highPrioritySensorIds() const;
91​ void setHighPrioritySensorIds(const QJsonArray &ids);
92​
93​ QJsonArray sensors() const;
94​
95​ QJsonArray lowPrioritySensorIds() const;
96​ void setLowPrioritySensorIds(const QJsonArray &ids);
97​
98​ QVariantMap sensorColors() const;
99​ void setSensorColors(const QVariantMap &colors);
100​
101​ // from face config, immutable by the user
102​ QString name() const;
103​ const QString icon() const;
104​
105​ bool supportsSensorsColors() const;
106​ bool supportsTotalSensors() const;
107​ bool supportsLowPrioritySensors() const;
108​
109​ QAbstractItemModel *availableFacesModel();
110​ QAbstractItemModel *availablePresetsModel();
111​
112​ Q_INVOKABLE void reloadConfig();
113​ Q_INVOKABLE void loadPreset(const QString &preset);
114​ Q_INVOKABLE void savePreset();
115​ Q_INVOKABLE void uninstallPreset(const QString &pluginId);
116​
117​Q_SIGNALS:
118​ void faceIdChanged();
119​ void titleChanged();
120​ void totalSensorsChanged();
121​ void highPrioritySensorIdsChanged();
122​ void lowPrioritySensorIdsChanged();
123​ void sensorsChanged();
124​ void sensorColorsChanged();
125​
126​private:
127​ class Private;
128​ const std::unique_ptr<Private> d;
129​};
130​}